Re: [patch 2.6.21-rc5-git 0/3] x86_pc and ACPI support /sys/devices/.../wakeup

[Zhang Rui <rui.zhang@intel.com>]

On Wed, 2007-04-18 at 09:33 -0700, David Brownell wrote:
> On Wednesday 18 April 2007 2:51 am, Zhang Rui wrote:
> > Hi, David,
> > 
> > On Thu, 2007-04-05 at 12:48 -0700, David Brownell wrote:
> > > Following are three patches for basic driver model wakeup flag support on
> > > PCs.  I think the first two are nearly mergable.  The third previously broke
> > > powerpc, so it's likely not yet mergeable ... the issue was arch-specific
> > > differences in PCI initialization, someone else will need to solve them.
> > > 
> > > The patches are:
> > > 
> > >  - Define a platform_enable_wakeup() PM hook and use it with PCI.  (This
> > >    might help OLPC with its non-RTC events...)
> > > 
> > >  - Make ACPI init and use driver model wakeup flags for the (motherboard)
> > >    devices in its table ... and implement that new platform hook.  Now
> > >    /proc/acpi/wakeup is almost purely informative.
> > 
> > Yes.
> > But /proc/acpi/wakeup is exporting the wrong information then.
> 
> I'd say it's always exported the wrong information ... and
> since those /proc files are going away, this there's no
> strong need to continue following that path.
> 
> The literal meaning hasn't changed:  it still reflects the
> value of the acpi_device.wakeup.state.enabled flag.  This
> version of the patch avoided changing that meaning, to make
> the compatibility story simpler.
> 
> > I.e. when a physical device is set to may_wakeup, the corresponding
> > GPE will be enabled before entering a system sleep state.
> 
> The GPE is not always enabled when device_may_wakeup(dev)
> returns true.  When drivers aren't set up to handle wakeups,
> they won't make requests that boil down to enabling GPEs.
> 
> What /proc/acpi/wakeup shows in those cases is the state
> of what I called "manual overrides".  Drivers that aren't
> wakeup-aware will use those settings ... same as always.
> (Unless userspace disables wakeup for that device through
> the driver model.)
> 

> Wakeup-aware drivers will manage their GPEs directly, by
> calling pci_enable_wake() -- or whatever -- according to
> what device_may_wakeup(dev) tells them to do.
> 

That's true.
Now acpi_device.wakeup.state.enabled is handled by
the wakeup-aware drivers of the "real" device.

I love the first two patches which help user space get rid of
this ACPI specific GPE control.

What I meant yesterday is that, as /proc/acpi/wakeup won't be
removed until we are able to map all the ACPI devices shown to
the real device node, if they have one,
it would be better if we either remove this GPE status information
from /proc/acpi/wakeup, or export something that really makes sense.
But now I think it's wrong. Because the other devices that are not
mapped yet still need this I/F to enable/disable GPE, we can not
remove/change this at the current stage.

Then the first two patches are OK with me.:)

Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Thanks,
Rui