Re: [PATCH 8/9] ACPI: thinkpad-acpi: add sysfs support to hotkey subdriver

Henrique de Moraes Holschuh
2007-05-06T16:09:28Z

On Sun, 06 May 2007, Luming Yu wrote:
> I don't like the idea of stuffing kernel space with model-specific
> knowledge (i.e. a table) even if it is in a driver. These tables
> should be in user space...

Yeah, I am reserving that option for stuff that absolutely must be in the
driver because it needs the knowledge to do something, and so far there is
nothing like that. Maybe the LEDs will require it to be properly named, but
that is a very small table of exceptions, much like a blacklist.

> >We deliver to userspace something like "Fn+F1" pressed, instead of "blank
> >screen" pressed, because "blank screen" is in different keys depending on
> >thinkpad model.
>
> Yes, you should generate generic key event through input layer..

It will move to the input layer eventually. Right now, they are ACPI
events.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh