From: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
To: lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Henrique de Moraes Holschuh
<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 3/9] ACPI: thinkpad-acpi: fix a fan watchdog invocation
Date: Fri, 27 Apr 2007 22:00:11 -0300 [thread overview]
Message-ID: <11777220173445-git-send-email-hmh@hmh.eng.br> (raw)
In-Reply-To: <11777220172751-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
The fan control watchdog was being called in one place even when the fan
control operation had failed. Fix it.
Signed-off-by: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
---
drivers/misc/thinkpad_acpi.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index f824259..b85f096 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -2888,9 +2888,10 @@ static ssize_t fan_pwm1_store(struct device *dev,
if (!rc && (status &
(TP_EC_FAN_AUTO | TP_EC_FAN_FULLSPEED)) == 0) {
rc = fan_set_level(newlevel);
- if (!rc)
+ if (!rc) {
fan_update_desired_level(newlevel);
- fan_watchdog_reset();
+ fan_watchdog_reset();
+ }
}
mutex_unlock(&fan_mutex);
--
1.5.1
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-04-28 1:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-28 1:00 [GIT PULL] thinkpad-acpi fixes and sysfs support part 2 (try 2) Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 1/9] ACPI: thinkpad-acpi: add a fan-control feature master toggle Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 2/9] ACPI: thinkpad-acpi: do not arm fan watchdog if it would not work Henrique de Moraes Holschuh
[not found] ` <11777220172751-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-04-28 1:00 ` Henrique de Moraes Holschuh [this message]
2007-05-03 17:00 ` [PATCH 3/9] ACPI: thinkpad-acpi: fix a fan watchdog invocation Thomas Renninger
2007-05-03 17:51 ` Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 4/9] ACPI: thinkpad-acpi: map ENXIO to EINVAL for fan sysfs Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 5/9] ACPI: thinkpad-acpi: improve fan control documentation Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 6/9] ACPI: thinkpad-acpi: improve debugging for acpi helpers Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 7/9] ACPI: thinkpad-acpi: improve dock subdriver initialization Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 8/9] ACPI: thinkpad-acpi: add sysfs support to hotkey subdriver Henrique de Moraes Holschuh
2007-04-29 1:47 ` Len Brown
2007-04-29 4:15 ` Henrique de Moraes Holschuh
2007-05-06 9:33 ` Luming Yu
2007-05-06 16:09 ` Henrique de Moraes Holschuh
2007-04-28 1:00 ` [PATCH 9/9] ACPI: thinkpad-acpi: add sysfs support to wan and bluetooth subdrivers Henrique de Moraes Holschuh
2007-04-29 1:48 ` [GIT PULL] thinkpad-acpi fixes and sysfs support part 2 (try 2) Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11777220173445-git-send-email-hmh@hmh.eng.br \
--to=hmh-n3tv7giv+o9fyo9q7ep/yw@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox