Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

jamal
2007-06-29T12:01:29Z

On Fri, 2007-29-06 at 13:51 +0200, Patrick McHardy wrote:

> Do multicast groups have to have a seperate name?

As i see it: the name would be unique per family
Its like DNS IP to name mapping essentially (in the simple case of IP
being globaly reachable). You do a discovery of the ID by knowing the
name.

> Or would it suffice
> to have them associated with the genl family and be able to find out
> the starting group number?

The id space is global.

> In that case something like
>
> struct genl_mc_groups {
> struct genl_family *family or char *family_name or similar;
> unsigned int group_off;
> unsigned int group_num;
> unsigned long groups[];
> };
>
> seems to make more sense since you only need a single struct
> per family.

I think something that ties to the family would be needed.

> >>>+static unsigned long mcast_group_start = 0x3;
> >>>+static unsigned long *multicast_groups = &mcast_group_start;
> >>>+static unsigned long multicast_group_bits = BITS_PER_LONG;
>
>
> That looks pretty similar.

I know-;> when i first saw it i asked myself "Hrm, where have i seen
that before?" ;->

> Why would you care about holes? If you really want to use sparse
> bitmaps that would complicate the code a lot.

similar to ifindices. You want to reuse/recycle them.

cheers,
jamal