From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Hughes Subject: Re: Add INPUT support to toshiba_acpi Date: Fri, 08 Jun 2007 15:30:16 +0100 Message-ID: <1181313016.2499.51.camel@work> References: <1180614979.2693.26.camel@localhost.localdomain> <1180788652.2355.27.camel@localhost.localdomain> <20070602142333.GA3452@srcf.ucam.org> <200706030048.40393.dtor@insightbb.com> <1181235539.2610.72.camel@work> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.173]:19939 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969102AbXFHOaQ (ORCPT ); Fri, 8 Jun 2007 10:30:16 -0400 Received: by ug-out-1314.google.com with SMTP id j3so967720ugf for ; Fri, 08 Jun 2007 07:30:15 -0700 (PDT) In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dmitry Torokhov Cc: Matthew Garrett , Bastien Nocera , John Belmonte , linux-kernel , linux-acpi On Fri, 2007-06-08 at 10:23 -0400, Dmitry Torokhov wrote: > On 6/7/07, Richard Hughes wrote: > > On Sun, 2007-06-03 at 00:48 -0400, Dmitry Torokhov wrote: > > > > > > > > > It looks like KEY_COFFE comes from 0x0c/0x19e - AL Terminal > > > Lock/Screensaver > > > so your interpretation is indeed correct. I guess I better add an > > > alias to > > > input.h > > > > What's the status of this patch? Good for merging? > > Not my call - John is the official maintainer of the driver. However > from input layer POV it looks good. Good, thanks. > > Do you want me to > > redo the current patch using input-polldev > > The patch I send to you earlier already does this. I am attaching a > refreshed version that used KEY_COFFEE instead of KEY_BREAK. Brilliant, these look great. > > and the new setkeycode stuff? > > And I have the patch doing this as well (attached). If you could > please give it a try I'd appreciate it. You beat me to it {hastily removes item from TODO...} :-) I'll give it a try as soon as possible, thanks. Richard.