linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Hughes <hughsient@gmail.com>
To: linux-acpi <linux-acpi@vger.kernel.org>
Cc: a_bartok@freemail.hu, Bastien Nocera <hadess@hadess.net>,
	David Zeuthen <david@fubar.dk>
Subject: [patch] Reporting the lid status using INPUT
Date: Fri, 15 Jun 2007 14:12:59 +0100	[thread overview]
Message-ID: <1181913179.21041.3.camel@work> (raw)
In-Reply-To: <1181910567.4819.7.camel@work>

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

On Fri, 2007-06-15 at 13:29 +0100, Richard Hughes wrote:
> in response to an event, but I'm thinking in a resume hook we should
> probably do acpi_evaluate_integer(handle, "_LID", NULL, &state) and then
> send an event, just so userspace is aware of what the state of the panel
> is.

Attached patch fixed the issue for me. Comments?

Richard.


[-- Attachment #2: acpi-resume-lid-event.patch --]
[-- Type: text/x-patch, Size: 1535 bytes --]

diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index cb4110b..3631b8f 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -68,6 +68,7 @@ MODULE_LICENSE("GPL");
 
 static int acpi_button_add(struct acpi_device *device);
 static int acpi_button_remove(struct acpi_device *device, int type);
+static int acpi_button_resume(struct acpi_device *device);
 static int acpi_button_info_open_fs(struct inode *inode, struct file *file);
 static int acpi_button_state_open_fs(struct inode *inode, struct file *file);
 
@@ -77,6 +78,7 @@ static struct acpi_driver acpi_button_driver = {
 	.ids = "button_power,button_sleep,PNP0C0D,PNP0C0C,PNP0C0E",
 	.ops = {
 		.add = acpi_button_add,
+		.resume = acpi_button_resume,
 		.remove = acpi_button_remove,
 	},
 };
@@ -487,6 +489,27 @@ static int acpi_button_remove(struct acpi_device *device, int type)
 	return 0;
 }
 
+/* this is needed to learn about changes made in suspended state */
+static int acpi_button_resume(struct acpi_device *device)
+{
+	struct acpi_button *button;
+	struct acpi_handle *handle;
+	struct input_dev *input;
+	unsigned long state;
+
+	button = device->driver_data;
+	handle = button->device->handle;
+	input = button->input;
+
+	/* on resume we send the state; it might be the same, but userspace
+	 * should handle duplicated events */
+	if (!ACPI_FAILURE(acpi_evaluate_integer(handle, "_LID",
+						NULL, &state)))
+		input_report_switch(input, SW_LID, !state);
+
+	return 0;
+}
+
 static int __init acpi_button_init(void)
 {
 	int result;

  reply	other threads:[~2007-06-15 13:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-15 12:29 Reporting the lid status using INPUT Richard Hughes
2007-06-15 13:12 ` Richard Hughes [this message]
2007-06-15 14:29   ` [patch] " Dmitry Torokhov
2007-06-15 14:53     ` Richard Hughes
2007-06-16 17:11       ` Richard Hughes
2007-06-16 17:51         ` Dmitry Torokhov
2007-06-24 22:06           ` GMail
2007-06-25 20:49             ` Bartók Albert
2007-06-25 21:24               ` Richard Hughes
2007-06-27 19:42               ` Richard Hughes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181913179.21041.3.camel@work \
    --to=hughsient@gmail.com \
    --cc=a_bartok@freemail.hu \
    --cc=david@fubar.dk \
    --cc=hadess@hadess.net \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).