Re: [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops

Johannes Berg
2007-06-26T08:49:47Z

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

On Sun, 2007-06-24 at 22:40 +0200, Rafael J. Wysocki wrote:

> + * @set_target: Tell the platform which system sleep state is going to be
> + * entered. The information passed to @set_target should be disregarded
> + * by the platform as soon as @finish() is executed and if @prepare()
> + * fails.
> + * This callback is optional. However, if it is implemented, the
> + * argument passed to @prepare(), @enter and @finish() must be ignored.

I don't understand the point in mandating that then the argument to
enter() is to be ignored, why bother? It doesn't look as though we can
possibly do anything with the semantics here that would mean the state
set by set_target is different to the state passed to enter(), can we?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]