Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

jamal
2007-06-30T15:32:21Z

On Fri, 2007-29-06 at 16:56 +0200, Johannes Berg wrote:

> +static void genl_unregister_mc_group(struct genl_multicast_group *grp)
> +{
> + /*
> + * TODO: fix multicast group re-use by clearing the bit
> + * for this group in all genetlink sockets.
> + */
> + clear_bit(grp->id, mc_groups);
> + list_del(&grp->list);

I think you need a
genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, family);
here? You may need to save the mcast details before you delete.

> + NLA_PUT_U32(skb, CTRL_ATTR_MCAST_GRP_ID, grp->id);
> + NLA_PUT_STRING(skb, CTRL_ATTR_MCAST_GRP_NAME,
> + grp->name);
> +

Consider my earlier suggestion to use CTRL_ATTR_MCAST_GRP which has both
id and name in one struct.

Other than that - looking good.

cheers,
jamal