Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

Johannes Berg
2007-07-02T08:43:33Z

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Sat, 2007-06-30 at 11:32 -0400, jamal wrote:

> > +static void genl_unregister_mc_group(struct genl_multicast_group *grp)
> > +{
> > + /*
> > + * TODO: fix multicast group re-use by clearing the bit
> > + * for this group in all genetlink sockets.
> > + */
> > + clear_bit(grp->id, mc_groups);
> > + list_del(&grp->list);
>
> I think you need a
> genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, family);
> here? You may need to save the mcast details before you delete.

I will, but not currently because right now mcast groups are only
deleted when the family is dropped.

> > + NLA_PUT_U32(skb, CTRL_ATTR_MCAST_GRP_ID, grp->id);
> > + NLA_PUT_STRING(skb, CTRL_ATTR_MCAST_GRP_NAME,
> > + grp->name);
> > +
>
> Consider my earlier suggestion to use CTRL_ATTR_MCAST_GRP which has both
> id and name in one struct.

Yeah I thought about that but then saw Patrick's patches to convert
other things away from structs so I wasn't sure what the idea here is.
Patrick, care to comment?

> Other than that - looking good.

:)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]