public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
To: lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Richard Hughes
	<hughsient-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Henrique de Moraes Holschuh
	<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: ACPI: thinkpad-acpi: register input device
Date: Sat, 14 Jul 2007 11:11:58 -0300	[thread overview]
Message-ID: <11844223331515-git-send-email-hmh@hmh.eng.br> (raw)
In-Reply-To: <11844223322928-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>

Register an input device to send input events to userspace.

This patch is based on a patch by Richard Hughes <hughsient-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>.

Signed-off-by: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
Cc: Richard Hughes <hughsient-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/misc/thinkpad_acpi.c |   32 +++++++++++++++++++++++++++++++-
 drivers/misc/thinkpad_acpi.h |    9 +++++++++
 2 files changed, 40 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index 4d71893..4427c99 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -510,13 +510,14 @@ static char *next_cmd(char **cmds)
 /****************************************************************************
  ****************************************************************************
  *
- * Device model: hwmon and platform
+ * Device model: input, hwmon and platform
  *
  ****************************************************************************
  ****************************************************************************/
 
 static struct platform_device *tpacpi_pdev;
 static struct class_device *tpacpi_hwmon;
+static struct input_dev *tpacpi_inputdev;
 
 static struct platform_driver tpacpi_pdriver = {
 	.driver = {
@@ -4363,6 +4364,20 @@ static int __init thinkpad_acpi_module_init(void)
 		thinkpad_acpi_module_exit();
 		return ret;
 	}
+	tpacpi_inputdev = input_allocate_device();
+	if (!tpacpi_inputdev) {
+		printk(IBM_ERR "unable to allocate input device\n");
+		thinkpad_acpi_module_exit();
+		return -ENOMEM;
+	} else {
+		/* Prepare input device, but don't register */
+		tpacpi_inputdev->name = "ThinkPad Extra Buttons";
+		tpacpi_inputdev->phys = IBM_DRVR_NAME "/input0";
+		tpacpi_inputdev->id.bustype = BUS_HOST;
+		tpacpi_inputdev->id.vendor = TPACPI_HKEY_INPUT_VENDOR;
+		tpacpi_inputdev->id.product = TPACPI_HKEY_INPUT_PRODUCT;
+		tpacpi_inputdev->id.version = TPACPI_HKEY_INPUT_VERSION;
+	}
 	for (i = 0; i < ARRAY_SIZE(ibms_init); i++) {
 		ret = ibm_init(&ibms_init[i]);
 		if (ret >= 0 && *ibms_init[i].param)
@@ -4372,6 +4387,14 @@ static int __init thinkpad_acpi_module_init(void)
 			return ret;
 		}
 	}
+	ret = input_register_device(tpacpi_inputdev);
+	if (ret < 0) {
+		printk(IBM_ERR "unable to register input device\n");
+		thinkpad_acpi_module_exit();
+		return ret;
+	} else {
+		tp_features.input_device_registered = 1;
+	}
 
 	return 0;
 }
@@ -4388,6 +4411,13 @@ static void thinkpad_acpi_module_exit(void)
 
 	dbg_printk(TPACPI_DBG_INIT, "finished subdriver exit path...\n");
 
+	if (tpacpi_inputdev) {
+		if (tp_features.input_device_registered)
+			input_unregister_device(tpacpi_inputdev);
+		else
+			input_free_device(tpacpi_inputdev);
+	}
+
 	if (tpacpi_hwmon)
 		hwmon_device_unregister(tpacpi_hwmon);
 
diff --git a/drivers/misc/thinkpad_acpi.h b/drivers/misc/thinkpad_acpi.h
index 78ea4c8..00f1bd7 100644
--- a/drivers/misc/thinkpad_acpi.h
+++ b/drivers/misc/thinkpad_acpi.h
@@ -39,6 +39,7 @@
 #include <linux/platform_device.h>
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
+#include <linux/input.h>
 #include <asm/uaccess.h>
 
 #include <linux/dmi.h>
@@ -48,6 +49,7 @@
 #include <acpi/acpi_drivers.h>
 #include <acpi/acnamesp.h>
 
+#include <linux/pci_ids.h>
 
 /****************************************************************************
  * Main driver
@@ -98,6 +100,11 @@ static const char *str_supported(int is_supported);
 #define vdbg_printk(a_dbg_level, format, arg...)
 #endif
 
+/* Input IDs */
+#define TPACPI_HKEY_INPUT_VENDOR	PCI_VENDOR_ID_IBM
+#define TPACPI_HKEY_INPUT_PRODUCT	0x5054 /* "TP" */
+#define TPACPI_HKEY_INPUT_VERSION	0x4101
+
 /* ACPI HIDs */
 #define IBM_HKEY_HID    "IBM0068"
 #define IBM_PCI_HID     "PNP0A03"
@@ -161,6 +168,7 @@ static int parse_strtoul(const char *buf, unsigned long max,
 static struct platform_device *tpacpi_pdev;
 static struct class_device *tpacpi_hwmon;
 static struct platform_driver tpacpi_pdriver;
+static struct input_dev *tpacpi_inputdev;
 static int tpacpi_create_driver_attributes(struct device_driver *drv);
 static void tpacpi_remove_driver_attributes(struct device_driver *drv);
 
@@ -233,6 +241,7 @@ static struct {
 	u16 light_status:1;
 	u16 wan:1;
 	u16 fan_ctrl_status_undef:1;
+	u16 input_device_registered:1;
 } tp_features;
 
 static struct list_head tpacpi_all_drivers;
-- 
1.5.2.1


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-07-14 14:11 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-14 14:11 [GIT PULL] thinkpad-acpi queue for 2.6.23 (v2) Henrique de Moraes Holschuh
     [not found] ` <11844223322928-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-07-14 14:11   ` ACPI: thinkpad-acpi: add DMI-based modalias Henrique de Moraes Holschuh
2007-07-14 14:11   ` ACPI: thinkpad-acpi: remove all uneeded initializers Henrique de Moraes Holschuh
2007-07-14 14:11   ` ACPI: thinkpad-acpi: update information on T43 thermal sensor 0xc1 Henrique de Moraes Holschuh
2007-07-14 14:11   ` ACPI: thinkpad-acpi: export hotkey maximum masks Henrique de Moraes Holschuh
2007-07-14 14:11   ` ACPI: thinkpad-acpi: export to sysfs the state of the radio slider switch Henrique de Moraes Holschuh
2007-07-14 14:11   ` ACPI: thinkpad-acpi: checkpoint sysfs interface version due to hotkey Henrique de Moraes Holschuh
2007-07-14 14:11   ` Henrique de Moraes Holschuh [this message]
2007-07-14 14:11   ` ACPI: thinkpad-acpi: add input device support to hotkey subdriver Henrique de Moraes Holschuh
2007-07-14 22:31     ` Matthew Garrett
     [not found]       ` <20070714223144.GA25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 18:12         ` Henrique de Moraes Holschuh
     [not found]           ` <20070715181233.GG14134-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 18:45             ` Matthew Garrett
     [not found]               ` <20070715184519.GD3235-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 20:03                 ` Henrique de Moraes Holschuh
2007-07-15 20:12                   ` [ibm-acpi-devel] " Matthew Garrett
2007-07-15 20:59                     ` Henrique de Moraes Holschuh
2007-07-15 21:04                       ` Matthew Garrett
2007-07-15 21:54                         ` Henrique de Moraes Holschuh
     [not found]                           ` <20070715215453.GJ19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 22:45                             ` Matthew Garrett
2007-07-16  2:47                               ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-16 15:46                           ` Dmitry Torokhov
2007-07-16 15:51                             ` Matthew Garrett
2007-07-16 18:19                               ` Henrique de Moraes Holschuh
2007-07-16 18:37                                 ` Matthew Garrett
2007-07-14 14:12   ` ACPI: thinkpad-acpi: add power-management handler capability Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: export EV_SW SW_RADIO events Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: checkpoint sysfs interface version due to input layer Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: rename pci HID constant Henrique de Moraes Holschuh
2007-07-14 22:37     ` Matthew Garrett
     [not found]       ` <20070714223713.GC25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 18:02         ` Henrique de Moraes Holschuh
2007-07-15 18:34           ` Matthew Garrett
2007-07-15 21:18             ` Henrique de Moraes Holschuh
2007-07-15 21:23               ` Matthew Garrett
2007-07-14 14:12   ` pci-ids: add Lenovo PCI vendor ID Henrique de Moraes Holschuh
2007-07-15 11:52     ` Jeff Garzik
2007-07-15 21:22       ` Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: store ThinkPad model information Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: allow use of CMOS NVRAM for brightness control Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key Henrique de Moraes Holschuh
2007-07-14 22:39     ` Matthew Garrett
     [not found]       ` <20070714223932.GD25782-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 17:59         ` Henrique de Moraes Holschuh
2007-07-15 18:31           ` Matthew Garrett
     [not found]             ` <20070715183150.GA3235-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 20:17               ` Henrique de Moraes Holschuh
     [not found]                 ` <20070715201712.GD19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 20:24                   ` Matthew Garrett
2007-07-14 14:12   ` ACPI: thinkpad-acpi: make sure DSDT TMPx readings don't return +128 Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: make EC-based thermal readings non-experimental Henrique de Moraes Holschuh
2007-07-14 14:12   ` ACPI: thinkpad-acpi: bump up version to 0.15 Henrique de Moraes Holschuh
2007-07-14 14:58   ` [GIT PULL] thinkpad-acpi queue for 2.6.23 (v2) Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: enable more hotkeys Henrique de Moraes Holschuh
2007-07-14 14:11 ` ACPI: thinkpad-acpi: update CMOS commands documentation Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad-acpi: make the input event mode the default Henrique de Moraes Holschuh
2007-07-14 22:33   ` Matthew Garrett
2007-07-15 18:05     ` Henrique de Moraes Holschuh
     [not found]       ` <20070715180529.GF14134-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 18:38         ` Matthew Garrett
2007-07-15 20:09           ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-15 20:13             ` Matthew Garrett
2007-07-15 21:14               ` Henrique de Moraes Holschuh
     [not found]                 ` <20070715211421.GG19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 21:19                   ` Matthew Garrett
     [not found]                     ` <20070715211953.GA6527-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
2007-07-15 22:08                       ` Henrique de Moraes Holschuh
     [not found]                         ` <20070715220801.GK19066-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-15 22:49                           ` Matthew Garrett
2007-07-16  0:12                             ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
     [not found]                               ` <20070716001239.GA31604-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-16  0:24                                 ` Matthew Garrett
2007-07-16  3:02                                   ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
     [not found]                                     ` <20070716030254.GD31604-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-07-16 15:27                                       ` Dmitry Torokhov
2007-07-16 18:21                                         ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2007-07-14 14:12 ` ACPI: thinkpad_acpi: use bool for boolean parameters Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11844223331515-git-send-email-hmh@hmh.eng.br \
    --to=hmh-n3tv7giv+o9fyo9q7ep/yw@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=hughsient-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox