From: Zhang Rui <rui.zhang@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Brown, Len" <len.brown@intel.com>, linux-acpi@vger.kernel.org
Subject: Re: [patch 7/8] ACPI: video - more cleanups
Date: Wed, 14 Nov 2007 15:18:11 +0800 [thread overview]
Message-ID: <1195024691.1262.48.camel@acpi-hp.sh.intel.com> (raw)
In-Reply-To: <20071105165012.815613696@anvil.corenet.prv>
On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
> ACPI: video - more cleanups
>
> Remove unneeded checks and initializations, implement proper
> unwinding after errors in initialization code, get rid of
> unneeded casts, adjust formatting.
A big patch with a large number of minor cleanups/fixes.
Thanks for your work, Dmitry.
I'm okay with this one except the comment below.
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> @@ -1772,12 +1783,11 @@ static int acpi_video_bus_stop_devices(s
> static void acpi_video_bus_notify(acpi_handle handle, u32 event, void
> *data)
> {
> struct acpi_video_bus *video = data;
> - struct acpi_device *device = NULL;
> + struct acpi_device *device;
> struct input_dev *input;
> int keycode;
>
> -
> - printk("video bus notify\n");
> + printk(KERN_DEBUG "video bus notify\n");
This debug message should be removed.
Thanks,
Rui
next prev parent reply other threads:[~2007-11-14 7:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 16:43 [patch 0/8] ACPI Video various cleanups & fixes Dmitry Torokhov
2007-11-05 16:43 ` [patch 1/8] ACPI: video - fit input device into sysfs tree Dmitry Torokhov
2007-11-14 7:17 ` Zhang Rui
2007-11-14 16:49 ` Len Brown
2007-11-05 16:43 ` [patch 2/8] ACPI: video - add missing input_free_device() Dmitry Torokhov
2007-11-14 7:17 ` Zhang Rui
2007-11-14 17:00 ` Len Brown
2007-11-05 16:43 ` [patch 3/8] ACPI: video - remove unsafe uses of list_for_each_safe() Dmitry Torokhov
2007-11-14 7:17 ` Zhang Rui
2007-11-14 17:46 ` Len Brown
2007-11-05 16:43 ` [patch 4/8] ACPI: video - convert semaphore to a mutex Dmitry Torokhov
2007-11-14 7:17 ` Zhang Rui
2007-11-14 17:18 ` Len Brown
2007-11-05 16:43 ` [patch 5/8] ACPI: video - simplify handling of attached devices Dmitry Torokhov
2007-11-14 7:17 ` Zhang Rui
2007-11-14 17:34 ` Len Brown
2007-11-05 16:43 ` [patch 6/8] ACPI: video - properly handle errors when registering proc elements Dmitry Torokhov
2007-11-14 7:18 ` Zhang Rui
2007-11-14 13:36 ` Henrique de Moraes Holschuh
2007-11-14 15:06 ` Dmitry Torokhov
2007-11-14 17:22 ` Len Brown
2007-11-14 17:38 ` Len Brown
2007-11-05 16:43 ` [patch 7/8] ACPI: video - more cleanups Dmitry Torokhov
2007-11-14 7:18 ` Zhang Rui [this message]
2007-11-14 17:42 ` Len Brown
2007-11-14 17:47 ` Len Brown
2007-11-05 16:43 ` [patch 8/8] ACPI: video - fix permissions on some proc entries Dmitry Torokhov
2007-11-14 7:18 ` Zhang Rui
2007-11-14 7:17 ` [patch 0/8] ACPI Video various cleanups & fixes Zhang Rui
2007-11-14 15:04 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195024691.1262.48.camel@acpi-hp.sh.intel.com \
--to=rui.zhang@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox