From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: Re: [patch 7/8] ACPI: video - more cleanups Date: Wed, 14 Nov 2007 15:18:11 +0800 Message-ID: <1195024691.1262.48.camel@acpi-hp.sh.intel.com> References: <20071105164328.982283020@anvil.corenet.prv> <20071105165012.815613696@anvil.corenet.prv> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:38109 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760508AbXKNHIX (ORCPT ); Wed, 14 Nov 2007 02:08:23 -0500 In-Reply-To: <20071105165012.815613696@anvil.corenet.prv> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dmitry Torokhov Cc: "Brown, Len" , linux-acpi@vger.kernel.org On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote: > ACPI: video - more cleanups > > Remove unneeded checks and initializations, implement proper > unwinding after errors in initialization code, get rid of > unneeded casts, adjust formatting. A big patch with a large number of minor cleanups/fixes. Thanks for your work, Dmitry. I'm okay with this one except the comment below. > Signed-off-by: Dmitry Torokhov > @@ -1772,12 +1783,11 @@ static int acpi_video_bus_stop_devices(s > static void acpi_video_bus_notify(acpi_handle handle, u32 event, void > *data) > { > struct acpi_video_bus *video = data; > - struct acpi_device *device = NULL; > + struct acpi_device *device; > struct input_dev *input; > int keycode; > > - > - printk("video bus notify\n"); > + printk(KERN_DEBUG "video bus notify\n"); This debug message should be removed. Thanks, Rui