From: Zhang Rui <rui.zhang@intel.com>
To: lenb@kernel.org, astarikovskiy@suse.de
Cc: linux-acpi@vger.kernel.org
Subject: [PATCH] ACPI: disable the gpe that doesn't have a GPE handler correctly
Date: Mon, 19 Nov 2007 15:32:46 +0800 [thread overview]
Message-ID: <1195457566.2971.12.camel@acpi-hp.sh.intel.com> (raw)
From: Zhang Rui <rui.zhang@intel.com>
The current code only disable the GPE by judging the
GPE type, which is one of WAKE, RUNTIME and WAKE_RUN.
In bug 6217, GPE 17 is enabled by the AML code ...
And it will be triggerred when an extra CRT is connected.
As GPE 17 is not ec gpe, and there is no _Lxx/_Exx method
exists in the _GPE scope, the type flag of GPE 17 is cleared
at the boot time and it's none of the three GPE types.
In this case, the GPE is not disabled correctly.
http://bugzilla.kernel.org/show_bug.cgi?id=6217
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/acpi/events/evgpe.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/acpi/events/evgpe.c
===================================================================
--- linux-2.6.orig/drivers/acpi/events/evgpe.c
+++ linux-2.6/drivers/acpi/events/evgpe.c
@@ -277,11 +277,10 @@ acpi_status acpi_ev_disable_gpe(struct a
/* Disable the requested runtime GPE */
ACPI_CLEAR_BIT(gpe_event_info->flags, ACPI_GPE_RUN_ENABLED);
- status = acpi_hw_write_gpe_enable_reg(gpe_event_info);
- break;
default:
- return_ACPI_STATUS(AE_BAD_PARAMETER);
+ acpi_hw_write_gpe_enable_reg(gpe_event_info);
+ break;
}
return_ACPI_STATUS(AE_OK);
next reply other threads:[~2007-11-19 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 7:32 Zhang Rui [this message]
2007-11-20 2:10 ` [PATCH] ACPI: disable the gpe that doesn't have a GPE handler correctly Zhang Rui
2007-11-20 8:55 ` Alexey Starikovskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195457566.2971.12.camel@acpi-hp.sh.intel.com \
--to=rui.zhang@intel.com \
--cc=astarikovskiy@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox