[patch] remove debug info in acpi video

[patch] remove debug info in acpi video

[Zhenyu Wang]

Remove acpi video debug message.

Signed-off-by: Zhenyu Wang <zhenyu.z.wang@intel.com>
---
 drivers/acpi/video.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index bac956b..9c8c8e6 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -1782,9 +1782,6 @@ static void acpi_video_bus_notify(acpi_handle handle, u32 event, void *data)
 	struct input_dev *input;
 	int keycode;
 
-
-	printk("video bus notify\n");
-
 	if (!video)
 		return;
 
-- 
1.5.3.3

Re: [patch] remove debug info in acpi video

[Zhang Rui]

On Tue, 2007-11-13 at 08:50 +0800, Zhenyu Wang wrote:
> 
> Remove acpi video debug message.
> 
> Signed-off-by: Zhenyu Wang <zhenyu.z.wang@intel.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>

> ---
>  drivers/acpi/video.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index bac956b..9c8c8e6 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -1782,9 +1782,6 @@ static void acpi_video_bus_notify(acpi_handle
> handle, u32 event, void *data)
>         struct input_dev *input;
>         int keycode;
> 
> -
> -       printk("video bus notify\n");
> -
>         if (!video)
>                 return;
> 
> --
> 1.5.3.3
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

No blacklight Re: [patch] remove debug info in acpi video

[Sergio Monteiro Basto]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

Since I begging to see this message on dmesg , when i press lid button ,
I don't have black light  


On Tue, 2007-11-13 at 10:36 +0800, Zhang Rui wrote:
> On Tue, 2007-11-13 at 08:50 +0800, Zhenyu Wang wrote:
> > 
> > Remove acpi video debug message.
> > 
> > Signed-off-by: Zhenyu Wang <zhenyu.z.wang@intel.com>
> Acked-by: Zhang Rui <rui.zhang@intel.com>
> 
> > ---
> >  drivers/acpi/video.c |    3 ---
> >  1 files changed, 0 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> > index bac956b..9c8c8e6 100644
> > --- a/drivers/acpi/video.c
> > +++ b/drivers/acpi/video.c
> > @@ -1782,9 +1782,6 @@ static void acpi_video_bus_notify(acpi_handle
> > handle, u32 event, void *data)
> >         struct input_dev *input;
> >         int keycode;
> > 
> > -
> > -       printk("video bus notify\n");
> > -
> >         if (!video)
> >                 return;
> > 
> > --
> > 1.5.3.3
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi"
> > in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Sérgio M. B.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2192 bytes --]

Re: No blacklight Re: [patch] remove debug info in acpi video

[Zhenyu Wang]

On 2007.11.25 00:21:50 +0000, Sergio Monteiro Basto wrote:
> Since I begging to see this message on dmesg ,
   
My patch just trys to remove that obvious debug printk, which
keeps showing up on one HP laptop. Someone may rework acpi 
debug level support in acpi video driver.

> when i press lid button , I don't have black light  
> 

No idea how could my simple patch cause your problem...

Re: No blacklight Re: [patch] remove debug info in acpi video

[Sergio Monteiro Basto]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]


On Mon, 2007-11-26 at 09:20 +0800, Zhenyu Wang wrote:
> No idea how could my simple patch cause your problem...

I'm not saying your patch cause the problem , I say when this messages
begging to appears at more or less at same time my blacklight stops to
works, but not saying that is direct related to this patch.

btw , after suspend to disk and resume , blacklight works! .

Just trying to help .

Thanks, 
-- 
Sérgio M. B.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2192 bytes --]

RE: No blacklight Re: [patch] remove debug info in acpi video

[Zhang, Rui]

>-----Original Message-----
>From: Sergio Monteiro Basto [mailto:sergio@sergiomb.no-ip.org]
>Sent: Tuesday, November 27, 2007 3:39 AM
>To: Wang, Zhenyu Z
>Cc: Zhang, Rui; linux-acpi@vger.kernel.org
>Subject: Re: No blacklight Re: [patch] remove debug info in acpi video
>
>
>On Mon, 2007-11-26 at 09:20 +0800, Zhenyu Wang wrote:
>> No idea how could my simple patch cause your problem...
>
>I'm not saying your patch cause the problem , I say when this messages
>begging to appears at more or less at same time my blacklight stops to
>works, but not saying that is direct related to this patch.
>
If the hotkey events is handled via ACPI, which is true in your case,
this debug message always appears no matter the backlight works or not.
:)

>btw , after suspend to disk and resume , blacklight works! .
That's weird.
You can open a bug at http://bugzilla.kernel.org/enter_bug.cgi
And attach the acpidump.

Thanks,
Rui