Re: [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems.

Len Brown
2008-01-24T04:35:18Z

On Wednesday 23 January 2008 21:55, Carlos Corbacho wrote:
> Why not just match on:
>
> > + .ident = "Acer",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> > + },
> > + },
>
> for all Acer laptops?

hmmm, because I assumed that dmi_check_system()
would do an exact string compare with "!strcmp()".

I'm surprised to discover it uses strstr() and matches
substrings instead. Is there logic behind that?

Certainly it makes using a single entry to match
a vendor problematic, as a short vendor string
could potentially be a substring of a different (unknown) vendor...

-Len