From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Rui" Subject: Re: [lm-sensors] The new thermal management sysfs class, and hwmon Date: Fri, 22 Feb 2008 16:33:26 +0800 Message-ID: <1203669206.3210.68.camel@localhost.localdomain> References: <20080203022622.GA995@khazad-dum.debian.net> <1202031072.3042.54.camel@acpi-sony.sh.intel.com> <20080203164410.GL20687@jupiter.solarsys.private> <20080203175006.GB9159@khazad-dum.debian.net> <05B550FD4BD2014E841D83547B626008029899FE@bgsmsx411.gar.corp.intel.com> <20080205135725.GO20687@jupiter.solarsys.private> <05B550FD4BD2014E841D83547B626008029BF29B@bgsmsx411.gar.corp.intel.com> <1202915450.7977.607.camel@queen.suse.de> <20080214140855.GB12412@srcf.ucam.org> <1203659229.3210.45.camel@localhost.localdomain> <47BE8105.30301@hhs.nl> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:31883 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbYBVIf1 (ORCPT ); Fri, 22 Feb 2008 03:35:27 -0500 In-Reply-To: <47BE8105.30301@hhs.nl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hans de Goede Cc: Matthew Garrett , Thomas Renninger , "Thomas, Sujith" , "Mark M. Hoffman" , Henrique de Moraes Holschuh , linux-acpi@vger.kernel.org, lm-sensors@lm-sensors.org, Jean Delvare , Len Brown , Richard Hughes Hi, Hans, On Fri, 2008-02-22 at 16:00 +0800, Hans de Goede wrote: > I think all that is really needed and asked for is for the new thermal > ACPI > code to: > 1) provide temp readings in the same format as hwmon (so milli degrees > celcius, > not degrees celcius Agree. > 2) provide a hwmon interface so that tools like (but not limited too): > * net-snmp > * mrtg > * sensors > * sensors-applet (gnome) > * xfce-sensors-applet > * ksysguard > * ksensors > * gkrellm > > Can provide temp and fan readings without having to be modified. hmm, for fan device, maybe something like this? pwm[1-*]_enable = 1 : manual fan control (using pwm[1-*]) 2+: automatic fan control (by acpi thermal driver) pwm[1-*] = 0 : fan is off. pwm[1-*] = 255: fan is on. pwm[1-*] has only two valid values as ACPI fan only support two states, ON/OFF. and it doesn't need fan[1-*]_input because the fan speed is not available. Yes, it can work for ACPI fan although I don't think the existing pwm hwmon I/F maps well to what we need and it seems like a "forced fit" to use it. Any better ideas? :) Thanks, Rui > To be clear I am suggesting that the new code exports both: > 1) the current full fledged thermal acpi zone interface, as designed > for > both reading and configuration > 2) a read only hwmon interface for reporting temps and fans