From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dmitry Torokhov <dtor@mail.ru>, Len Brown <len.brown@intel.com>
Subject: [PATCH] ACPI: video - fix permissions on some proc entries
Date: Sat, 23 Feb 2008 01:18:22 -0500 [thread overview]
Message-ID: <1203747502-4780-5-git-send-email-lenb@kernel.org> (raw)
In-Reply-To: <1203747502-4780-1-git-send-email-lenb@kernel.org>
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
POST and DOS are supposed to be writable but permissions
did not allow it.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/video.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 2268ab6..831f5f4 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -1276,7 +1276,7 @@ static int acpi_video_bus_add_fs(struct acpi_device *device)
entry->owner = THIS_MODULE;
/* 'POST' [R/W] */
- entry = create_proc_entry("POST", S_IFREG | S_IRUGO | S_IRUSR,
+ entry = create_proc_entry("POST", S_IFREG | S_IRUGO | S_IWUSR,
device_dir);
if (!entry)
goto err_remove_post_info;
@@ -1287,7 +1287,7 @@ static int acpi_video_bus_add_fs(struct acpi_device *device)
entry->owner = THIS_MODULE;
/* 'DOS' [R/W] */
- entry = create_proc_entry("DOS", S_IFREG | S_IRUGO | S_IRUSR,
+ entry = create_proc_entry("DOS", S_IFREG | S_IRUGO | S_IWUSR,
device_dir);
if (!entry)
goto err_remove_post;
--
1.5.4.2.184.gb23b
prev parent reply other threads:[~2008-02-23 6:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-23 6:18 video cleanup patches dropped Len Brown
2008-02-23 6:18 ` [PATCH] ACPI: video - do not store invalid entries in attached_array list Len Brown
2008-02-23 6:18 ` [PATCH] ACPI: video - properly handle errors when registering proc elements Len Brown
2008-02-23 6:18 ` [PATCH] ACPI: video - more cleanups Len Brown
2008-02-23 6:18 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203747502-4780-5-git-send-email-lenb@kernel.org \
--to=lenb@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@mail.ru \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox