From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harvey Harrison Subject: Re: [patch] x86: phase out forced inlining Date: Tue, 04 Mar 2008 10:14:13 -0800 Message-ID: <1204654453.5698.17.camel@brick> References: <20080301183550.GC25835@cs181133002.pp.htv.fi> <20080303085720.GD15943@elte.hu> <20080303091314.GC4457@cs181133002.pp.htv.fi> <20080303091714.GA18250@elte.hu> <20080303093103.GA23651@uranus.ravnborg.org> <20080303103933.GC21190@elte.hu> <20080303113451.GF4457@cs181133002.pp.htv.fi> <20080303114533.GA4183@elte.hu> <20080303121335.GA15381@elte.hu> <20080303145623.GA25697@uranus.ravnborg.org> <20080304164605.GA16379@elte.hu> <1204654039.5698.13.camel@brick> <47CD9060.9000708@zytor.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from wa-out-1112.google.com ([209.85.146.183]:5628 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760299AbYCDSOT (ORCPT ); Tue, 4 Mar 2008 13:14:19 -0500 Received: by wa-out-1112.google.com with SMTP id v27so1058141wah.23 for ; Tue, 04 Mar 2008 10:14:16 -0800 (PST) In-Reply-To: <47CD9060.9000708@zytor.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "H. Peter Anvin" Cc: Ingo Molnar , Sam Ravnborg , Adrian Bunk , Alexey Starikovskiy , lenb@kernel.org, astarikovskiy@suse.de, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Arjan van de Ven , Thomas Gleixner On Tue, 2008-03-04 at 10:09 -0800, H. Peter Anvin wrote: > Harvey Harrison wrote: > > > >> __inline__ : 1380 > > > > Lots of them in include/asm-*...not sure if there is a reason for this. > > > > Preferred form for code that's exported to userspace (since gcc > complains with -ansi -pedantic otherwise.) > Figured it would be something like that. Would it be reasonable to move towards eliminating __inline? Also, since the exported headers already go through unifdef, could we move to using inline everywhere in the kernel and add a processing step to make it __inline__ in the exported headers? Harvey