public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Johann Felix Soden <johfel@gmx.de>
To: Len Brown <len.brown@intel.com>
Cc: linux-acpi@vger.kernel.org
Subject: [PATCH] buffer array one byte too short in drivers/acpi/system.c
Date: Thu, 06 Mar 2008 15:30:53 +0100	[thread overview]
Message-ID: <1204813853.25336.3.camel@localhost> (raw)

From: Johann Felix Soden <johfel@users.sourceforge.net>

Since "ff_gbl_lock" has a length of 10 chars and is copied with sprintf to
char buffer[10], there is a problem because of the closing zero byte. We
need char buffer[11].

Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
---
 drivers/acpi/system.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/system.c b/drivers/acpi/system.c
index 55cf4c0..037b679 100644
--- a/drivers/acpi/system.c
+++ b/drivers/acpi/system.c
@@ -319,7 +319,7 @@ void acpi_irq_stats_init(void)
 		goto fail;
 
 	for (i = 0; i < num_counters; ++i) {
-		char buffer[10];
+		char buffer[11];
 		char *name;
 
 		if (i < num_gpes)
-- 
1.5.4.3




             reply	other threads:[~2008-03-06 14:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 14:30 Johann Felix Soden [this message]
2008-03-11  7:05 ` [PATCH] buffer array one byte too short in drivers/acpi/system.c Len Brown
2008-03-11 15:44   ` Johann Felix Soden
2008-03-12 22:23     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204813853.25336.3.camel@localhost \
    --to=johfel@gmx.de \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox