public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/3] [2.6.25-rc5] Warn user about a BIOS bug in recent asus boards
@ 2008-03-12  0:06 Thomas Renninger
  2008-03-12  4:10 ` Len Brown
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Renninger @ 2008-03-12  0:06 UTC (permalink / raw)
  To: Len Brown; +Cc: linux-acpi, Zhang, Rui

Warn user about a BIOS bug in recent asus boards

Do copy passive devices only if they are valid.

Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>

---
 drivers/acpi/thermal.c |   20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

Index: linux-2.6.24/drivers/acpi/thermal.c
===================================================================
--- linux-2.6.24.orig/drivers/acpi/thermal.c
+++ linux-2.6.24/drivers/acpi/thermal.c
@@ -440,16 +440,18 @@ static int acpi_thermal_trips_update(str
 		memset(&devices, 0, sizeof(struct acpi_handle_list));
 		status = acpi_evaluate_reference(tz->device->handle, "_PSL",
 							NULL, &devices);
-		if (ACPI_FAILURE(status))
-			tz->trips.passive.flags.valid = 0;
-		else
+		if (ACPI_SUCCESS(status)) {
 			tz->trips.passive.flags.valid = 1;
-
-		if (memcmp(&tz->trips.passive.devices, &devices,
-				sizeof(struct acpi_handle_list))) {
-			memcpy(&tz->trips.passive.devices, &devices,
-				sizeof(struct acpi_handle_list));
-			ACPI_THERMAL_TRIPS_EXCEPTION(flag, "device");
+			if (memcmp(&tz->trips.passive.devices, &devices,
+				   sizeof(struct acpi_handle_list))) {
+				memcpy(&tz->trips.passive.devices, &devices,
+				       sizeof(struct acpi_handle_list));
+				ACPI_THERMAL_TRIPS_EXCEPTION(flag, "device");
+			}
+		} else {
+			tz->trips.passive.flags.valid = 0;
+			ACPI_EXCEPTION((AE_INFO, status, "Invalid passiv trip"
+					" point\n"));
 		}
 	}
 	if ((flag & ACPI_TRIPS_PASSIVE) || (flag & ACPI_TRIPS_DEVICES)) {





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2008-03-31  5:55 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-12  0:06 [PATCH 3/3] [2.6.25-rc5] Warn user about a BIOS bug in recent asus boards Thomas Renninger
2008-03-12  4:10 ` Len Brown
2008-03-12  5:40   ` Len Brown
2008-03-12  5:44     ` Zhang, Rui
2008-03-12  7:12       ` Zhang, Rui
2008-03-13  7:03         ` Zhang, Rui
2008-03-13 21:15           ` Németh Márton
2008-03-30  0:43             ` Yinghai Lu
2008-03-31  5:55               ` Németh Márton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox