From: Thomas Renninger <trenn@suse.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Len Brown <lenb@kernel.org>, "Zhang, Rui" <rui.zhang@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>,
Hans de Goede <j.w.r.degoede@hhs.nl>
Subject: Re: [PATCH 1/2] thermal: add hwmon sys I/F for thermal device
Date: Fri, 14 Mar 2008 10:03:16 +0100 [thread overview]
Message-ID: <1205485397.21619.35.camel@queen.suse.de> (raw)
In-Reply-To: <20080313230919.GG30864@khazad-dum.debian.net>
On Thu, 2008-03-13 at 20:09 -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 13 Mar 2008, Thomas Renninger wrote:
> > This also happens in drivers/misc/thinkpad_acpi.c.
>
> I was sure I had removed __exit from every thinkpad-acpi exit handler that
> was also called from __init a long time ago...
>
> Let's see... nope, there isn't a single instance of __exit in
> thinkpad-acpi.c, so I must have misunderstood you. I do have lots of
> __init code, but I don't get any warnings from gcc 4.3 about that on ia32.
Ahh, I just checked that the module_init function calls the module_exit
function...
But the module_exit function probably because of this is not declared
__exit.
This looks a bit uncommon. I don't know whether it should be avoided,
but I cannot see why it should hurt.
Thomas
next prev parent reply other threads:[~2008-03-14 9:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 0:37 [PATCH 1/2] thermal: add hwmon sys I/F for thermal device Zhang, Rui
2008-03-12 4:29 ` Len Brown
2008-03-13 5:09 ` Len Brown
2008-03-13 8:46 ` Zhang, Rui
2008-03-18 4:59 ` Len Brown
2008-03-13 10:59 ` Thomas Renninger
2008-03-13 23:09 ` Henrique de Moraes Holschuh
2008-03-14 9:03 ` Thomas Renninger [this message]
2008-03-15 4:25 ` [lm-sensors] " Henrique de Moraes Holschuh
-- strict thread matches above, loose matches on Subject: below --
2008-02-25 21:31 Zhang, Rui
2008-02-26 8:39 ` Hans de Goede
2008-02-26 21:40 ` Zhang, Rui
2008-02-27 8:32 ` Hans de Goede
2008-03-17 12:37 ` Jean Delvare
2008-03-17 12:55 ` Hans de Goede
2008-03-17 13:48 ` Jean Delvare
2008-03-18 3:45 ` Zhang, Rui
2008-03-18 10:06 ` Jean Delvare
2008-03-20 14:58 ` Henrique de Moraes Holschuh
2008-03-18 5:12 ` Len Brown
2008-03-18 9:44 ` Jean Delvare
2008-03-18 3:11 ` Zhang, Rui
2008-03-18 1:59 ` Zhang, Rui
2008-03-18 9:25 ` Hans de Goede
2008-03-18 9:40 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205485397.21619.35.camel@queen.suse.de \
--to=trenn@suse.de \
--cc=hmh@hmh.eng.br \
--cc=j.w.r.degoede@hhs.nl \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox