Re: [PATCH 2/3] thermal: add hwmon sys I/F

Jean Delvare
2008-04-07T10:22:50Z

Quoting myself...

On Mon, 7 Apr 2008 11:46:48 +0200, Jean Delvare wrote:
> One thing that worries me is the hwmon device name. It comes directly
> from the thermal zone's type ("ACPI thermal zone" in the ACPI case".)
> We have no control over that name, while libsensors makes some
> assumptions on it. For example it assumes that there is no dash in a
> hwmon device name. So far, all hwmon device names also didn't have
> spaces, nor uppercase letters, and were much shorter (ACPI thermal zone
> would be something like "acpi_tz".) I hope that applications didn't
> make too many assumptions on length or content...
>
> I'm not sure yet if and how we want to address this problem. Maybe we
> could have a "short name" field in struct thermal_zone_device. Or
> alternatively I could add a conversion function to libsensors, that
> would convert "ACPI thermal zone" to "acpi_thermal_zone". The latter
> approach doesn't help with the length, but at least it normalizes the
> character set.

Oh, I now see that you addressed the problem in patch 3/3, so you can
forget about what I wrote above. Thank you :)

--
Jean Delvare