Re: [PATCH] ACPI: Support Fujitsu Lifebook S6410 in fujitsu-laptop

Jonathan Woithe
2008-04-15T03:39:12Z

> > There probably are machines out there which only have one of above
> > devices, then only the relevant driver should be loaded.
>
> I thought the since there is only a small functionality in each part and
> the module only registers drivers which are started only if an
> appropriate device is present it might be good to integrate it in one
> module. (in the S6410 case there is actually a third device FUJ02E1 but
> I don't know yet what it is for, there are some notifies for that device
> in the DSDT but so far I haven't triggered any of them)

A fair point. I guess it really depends on how these devices end up being
structured. Modularity enforces separation which can help with
maintainability going forward but it can also give rise to a certain
amount of code duplication. I'd be interested to see what others think.

Regards
jonathan