Re: [PATCH 2/2] patch acpi_lenovo_thinkpad_only_return_vista.patch

Thomas Renninger
2008-08-02T17:04:14Z

On Saturday 02 August 2008 06:57:59 pm Thomas Renninger wrote:
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> ---
> drivers/acpi/osl.c | 11 +++++++++++
> drivers/net/wireless/iwlwifi/iwl-led.c | 2 --
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index bf42ef1..0d9e174 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -201,6 +201,17 @@ acpi_status __init acpi_os_initialize(void)
>
> acpi_status acpi_os_initialize1(void)
> {
> + /* Only return Vista 2006 for Lenovo ThinkPads */
> + if (dmi_name_in_vendors("LENOVO")) {
> + acpi_osi_invalidate("Windows 2000");
> + acpi_osi_invalidate("Windows 2001");
> + acpi_osi_invalidate("Windows 2001 SP1");
> + acpi_osi_invalidate("Windows 2001 SP2");
> + acpi_osi_invalidate("Windows 2001.1");
> + acpi_osi_invalidate("Windows 2001.1 SP1");
> + /* acpi_osi_invalidate("Windows 2006"); */
> + }
> +
> kacpid_wq = create_singlethread_workqueue("kacpid");
> kacpi_notify_wq = create_singlethread_workqueue("kacpi_notify");
> BUG_ON(!kacpid_wq);

Ops, the stuff below is unrelated.

> diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c
> b/drivers/net/wireless/iwlwifi/iwl-led.c index 899d7a2..34de711 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-led.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-led.c
> @@ -195,8 +195,6 @@ static void iwl_led_brightness_set(struct led_classdev
> *led_cdev, return;
>
>
> - IWL_DEBUG_LED("Led type = %s brightness = %d\n",
> - led_type_str[led->type], brightness);
> switch (brightness) {
> case LED_FULL:
> if (led->type == IWL_LED_TRG_ASSOC)

Also the first patch probably disables video.ko brightness switching and
thinkpad_acpi has to be used then. The way it worked before Vista...

But only returning true to Windows 2006, is worth a try IMO.

Thomas