From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Len Brown <lenb@kernel.org>
Subject: RE: Oops in ACPI with git latest
Date: Thu, 23 Oct 2008 20:27:22 -0500 [thread overview]
Message-ID: <1224811642.3330.57.camel@localhost.localdomain> (raw)
In-Reply-To: <4911F71203A09E4D9981D27F9D830858033D1CC9@orsmsx503.amr.corp.intel.com>
On Thu, 2008-10-23 at 15:34 -0700, Moore, Robert wrote:
> + if (!output.pointer)
> + return AE_NULL_OBJECT;
> +
>
> This probably won't work. acpi_evaluate_object currently doesn't touch the pointer parameter if there is no return value, it only sets the length to zero.
Actually, it does.
> So, you might try this:
>
> + if (!output.length)
> + return AE_NULL_OBJECT;
> +
This also works.
James
next prev parent reply other threads:[~2008-10-24 1:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 19:45 Oops in ACPI with git latest James Bottomley
2008-10-23 20:42 ` Rafael J. Wysocki
2008-10-23 22:34 ` Moore, Robert
2008-10-24 1:27 ` James Bottomley [this message]
2008-10-24 6:57 ` Rafael J. Wysocki
2008-10-24 11:49 ` [PATCH] Subject: Prevent acpi_run_osc from using NULL objects (was: Re: Oops in ACPI with git latest) Rafael J. Wysocki
2008-10-24 15:02 ` Moore, Robert
2008-10-24 20:27 ` Len Brown
2008-10-24 20:43 ` Moore, Robert
2008-10-24 14:57 ` Oops in ACPI with git latest Moore, Robert
2008-10-24 18:04 ` Jesse Barnes
2008-10-24 18:43 ` Rafael J. Wysocki
2008-10-24 19:22 ` Jesse Barnes
2008-10-24 19:50 ` Rafael J. Wysocki
2008-10-24 20:42 ` Len Brown
2008-10-24 1:17 ` James Bottomley
2008-10-24 6:47 ` Rafael J. Wysocki
2008-10-24 15:04 ` Moore, Robert
2008-10-24 1:17 ` Lin Ming
2008-10-24 15:37 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224811642.3330.57.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox