Re: [PATCH v2 0/8] ACPI: thermal: Use trip point table to register thermal zones

Daniel Lezcano
2023-07-23T10:19:29Z

Hi Rafael,

could you wait before applying I would like to review the series but I'm
OoO ATM, coming back next week?

On 21/07/2023 14:44, Rafael J. Wysocki wrote:
> Hi Everyone,
>
> This is the second iteration of the $subject patch series and its original
> description below is still applicable
>
> On Tuesday, July 18, 2023 8:01:20 PM CEST Rafael J. Wysocki wrote:
>>
>> This patch series makes the ACPI thermal driver register thermal zones
>> with the help of thermal_zone_device_register_with_trips(), so it
>> doesn't need to use the thermal zone callbacks related to trip points
>> any more (and they are dropped in the last patch).
>>
>> The approach presented here is quite radically different from the
>> previous attempts, as it doesn't really rearrange the driver's
>> internal data structures, but adds the trip table support on top of
>> them. For this purpose, it uses an additional field in struct thermal_trip
>> introduced in the first patch.
>
> In the meantime I have updated the patches and tested them on a system with
> a couple of ACPI thermal zones. No differences in functionality after applying
> the patches have been observed.
>
> The update is mostly related to adding extra locking around trip point
> temperature updates and some hardening of the .get_trend() callback routine
> against invalid trip point indices.
>
> Please see patch changelogs for details.
>
> Thanks!
>
>
>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |