public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Thomas Renninger <trenn@suse.de>, Andi Kleen <ak@linux.intel.com>,
	Len Brown <len.brown@intel.com>
Subject: [PATCH 04/10] asus-acpi: fingers off backlight if video.ko is serving this functionality
Date: Sat, 08 Nov 2008 01:14:23 -0500	[thread overview]
Message-ID: <1226124869-1878-5-git-send-email-lenb@kernel.org> (raw)
In-Reply-To: <1226124869-1878-1-git-send-email-lenb@kernel.org>

From: Thomas Renninger <trenn@suse.de>

Signed-off-by: Thomas Renninger <trenn@suse.de>
Acked-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/misc/asus-laptop.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index a9d5228..8fb8b35 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -1208,9 +1208,13 @@ static int __init asus_laptop_init(void)
 
 	dev = acpi_get_physical_device(hotk->device->handle);
 
-	result = asus_backlight_init(dev);
-	if (result)
-		goto fail_backlight;
+	if (!acpi_video_backlight_support()) {
+		result = asus_backlight_init(dev);
+		if (result)
+			goto fail_backlight;
+	} else
+		printk(ASUS_INFO "Brightness ignored, must be controlled by "
+		       "ACPI video driver\n");
 
 	result = asus_led_init(dev);
 	if (result)
-- 
1.6.0.3.640.g6331a


  parent reply	other threads:[~2008-11-08  6:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-08  6:14 video patches in ACPI test tree Len Brown
2008-11-08  6:14 ` [PATCH 01/10] ACPI: video: Ignore devices that aren't present in hardware Len Brown
2008-11-08  6:14 ` [PATCH 02/10] ACPI video: if no ACPI backlight support, use vendor drivers Len Brown
2008-11-08  6:14 ` [PATCH 03/10] Acer-WMI: fingers off backlight if video.ko is serving this functionality Len Brown
2008-11-08  6:14 ` Len Brown [this message]
2008-11-08  6:14 ` [PATCH 05/10] compal: " Len Brown
2008-11-08  6:14 ` [PATCH 06/10] eeepc-laptop: " Len Brown
2008-11-08  6:14 ` [PATCH 07/10] fujitsu-laptop: " Len Brown
2008-11-08  6:14 ` [PATCH 08/10] msi-laptop: " Len Brown
2008-11-08  6:14 ` [PATCH 09/10] sony-laptop: " Len Brown
2008-11-08  6:14 ` [PATCH 10/10] thinkpad_acpi: " Len Brown
  -- strict thread matches above, loose matches on Subject: below --
2008-08-01 15:37 Check for ACPI backlight support otherwise use vendor ACPI drivers - version 4 Thomas Renninger
2008-08-01 15:37 ` [PATCH 04/10] asus-acpi: fingers off backlight if video.ko is serving this functionality Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226124869-1878-5-git-send-email-lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox