Re: ACPI crash on lid close - SMP race?

Sergio Monteiro Basto
2008-11-10T23:52:58Z

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

On Mon, 2008-11-10 at 17:29 +0000, Matthew Garrett wrote:
> On Mon, Nov 10, 2008 at 05:26:35PM +0000, Sergio Monteiro Basto wrote:
> > Hi, About this _DOS , I reported this problem a long time ago, which now
> > is on http://bugzilla.kernel.org/show_bug.cgi?id=6001
> > Could you put yours comment on it ?
> >
> > On fedora stock kernel, appears one patch, (Now I see that you are the
> > author :) )
> >
> > I tested your patch and it works for me !
>
> Yeah, that's the "safe" patch which stops us executing the codepath that
> breaks, but also means I don't get display switch events. Having it set
> to 1 means executing BIOS code that's likely to interfere with the rest
> of the system, so a crash isn't surprising.

Are you talking about 1st or 2nd parameter ?
I prefer
"return acpi_video_bus_DOS(video, 1, 0);" (which is the original code,
before last change on kernel vanilla)

> But a setting of 0 *should*
> be safe, and I'm quite confused as to why it's exploding.

The second parameter ?
I got some instability (after resume from disk) with a
kernel-2.6.27.4-79, which have yours patch, but I am far to be sure that
is related.

Thanks,
--
Sérgio M. B.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2192 bytes --]