Linux ACPI
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Thomas, Sujith" <sujith.thomas@intel.com>
Subject: Re: [PATCH] acpi: move thermal trip handling to generic thermal layer
Date: Wed, 17 Dec 2008 11:02:18 +0800	[thread overview]
Message-ID: <1229482938.562.29.camel@rzhang-dt> (raw)
In-Reply-To: <20081208125904.GA31976@srcf.ucam.org>

On Mon, 2008-12-08 at 20:59 +0800, Matthew Garrett wrote:
> On Mon, Dec 08, 2008 at 02:59:00PM +0800, Zhang Rui wrote:
> > On Thu, 2008-12-04 at 01:55 +0800, Matthew Garrett wrote:
> > > The ACPI code currently carries its own thermal trip handling, meaning that
> > > any other thermal implementation will need to reimplement it. Move the code
> > > to the generic thermal layer.
> > > 
> > Are these ACPI stuffs generic enough to be ported to the generic thermal
> > driver?
> > e.g. the tc1, tc2, tsp, they are mentioned in the ACPI spec, 
> > so my question is if the thermal zones than ACPI still have these
> > concepts?
> 
> They're needed if you want to implement any sort of sensible 
> implementation of passive cooling. They might not be expressed in quite 
> the same way, but the basic concept is identical.

Seeing tc1, tc2, tsp under /sys/class/thermal/ is not good because we
don't want to make the generic thermal driver too ACPI specific, before
we've really concluded some basic concepts for passive cooling.
so why not do this after we have another generic thermal user with
passive cooling support?

thanks,
rui


  reply	other threads:[~2008-12-17  3:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27 17:48 [PATCH] thermal: use integers rather than strings for thermal values Matthew Garrett
2008-11-27 17:49 ` Matthew Garrett
2008-11-28  2:52   ` Zhang Rui
2009-01-16 13:44     ` Thomas Renninger
2008-12-03 17:55   ` [PATCH] acpi: move thermal trip handling to generic thermal layer Matthew Garrett
2008-12-03 18:00     ` [PATCH] thermal: support forcing support for passive cooling Matthew Garrett
2008-12-17  3:19       ` Zhang Rui
2008-12-28 15:22       ` Matthew Garrett
2009-01-06 22:42         ` Matthew Garrett
2009-02-13  1:21           ` Matthew Garrett
2009-02-20 23:45       ` Len Brown
2008-12-08  6:59     ` [PATCH] acpi: move thermal trip handling to generic thermal layer Zhang Rui
2008-12-08 12:59       ` Matthew Garrett
2008-12-17  3:02         ` Zhang Rui [this message]
2008-12-17  3:12           ` Matthew Garrett
2009-01-16 13:48             ` Thomas Renninger
2009-02-20 16:53               ` Len Brown
2009-02-20 23:44     ` Len Brown
2009-02-20 15:56 ` [PATCH] thermal: use integers rather than strings for thermal values Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229482938.562.29.camel@rzhang-dt \
    --to=rui.zhang@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=sujith.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox