public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Subject: _DIS ACPI PCI Interrupt Links
Date: Fri, 19 Dec 2008 03:22:50 -0500	[thread overview]
Message-ID: <1229674972-1511-1-git-send-email-lenb@kernel.org> (raw)

We've had the reference counting on Links disabled
since 2.6.12.  Time to try to enable it and re-learn
why we disabled it back then:-)

This allows links to get back into the _DISabled state
when drivers free IRQs.  They may free IRQs at
unload time, or at suspend time.

For suspend, this allows us to "act more like boot",
in that links start off in _DIS and are programmed
as the drivers request them.

irqrouter_resume() will still restore the
links that were not in the _DIS state at suspend.
(Though I really don't like this routine, and how
 it runs AML with irqs disabled)

One opportunity for a bug on resume we may have is
that we don't actually force all the links to _DIS
before we start programming them as we do at boot time.
We can add that if it turns out to be a problem --
but would do it with interrupts on, like we do at boot...

Anyway, this all works for me...
If Rafael comes through with PCI Core code to
free IRQ at suspend for all devices, then we may
find outselves very close to the state where all
the links are disabled at suspend and irqrouter_resume()
has nothing to do.


cheers,
-- Len Brown - Intel Open Source Technology Center

             reply	other threads:[~2008-12-19  8:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-19  8:22 Len Brown [this message]
2008-12-19  8:22 ` [PATCH 1/2] ACPI: update pci_link debug messages Len Brown
2008-12-19  8:22   ` [PATCH 2/2] ACPI: PCI Interrupt Links -- disable when unused Len Brown
2008-12-19  9:10     ` Yinghai Lu
2008-12-19  9:33       ` Len Brown
2008-12-19 11:57         ` Yinghai Lu
2008-12-19 18:39           ` Len Brown
2008-12-19 20:21             ` Yinghai Lu
2009-01-09  6:55               ` why kexec (was Re: [PATCH 2/2] ACPI: PCI Interrupt Links -- disable when unused) Len Brown
2009-01-09  7:24                 ` Yinghai Lu
2009-01-09 10:30                   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229674972-1511-1-git-send-email-lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox