Re: [PATCH 2/2] ACPI: PCI Interrupt Links -- disable when unused

Len Brown
2008-12-19T18:39:36Z

> > drivers/acpi/pci_link.c | 11 -----------
> > 1 files changed, 0 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> > index 595b131..0f7722d 100644
> > --- a/drivers/acpi/pci_link.c
> > +++ b/drivers/acpi/pci_link.c
> > @@ -693,18 +693,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
> > printk(KERN_ERR PREFIX "Link isn't initialized\n");
> > return -1;
> > }
> > -#ifdef FUTURE_USE
> > - /*
> > - * The Link reference count allows us to _DISable an unused link
> > - * and suspend time, and set it again on resume.
> > - * However, 2.6.12 still has irq_router.resume
> > - * which blindly restores the link state.
> > - * So we disable the reference count method
> > - * to prevent duplicate acpi_pci_link_set()
> > - * which would harm some systems
> > - */
> > link->refcnt--;
> > -#endif
> > ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> > "Link %s is dereferenced %d\n",
> > acpi_device_bid(link->device), link->refcnt));
> > --
>
> maybe could have one switch in /proc so could not disable that for
> some kexec path...

I fail to comprehend the benefits of kexec,
and the requirements that kexec puts on the kernel, other than:

# CONFIG_KEXEC is not set

-- Len Brown, Intel Open Source Technology Center