public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: linux-acpi <linux-acpi@vger.kernel.org>, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 2/2] video: mark "actual_brightness" deprecated
Date: Wed, 31 Dec 2008 10:12:16 +0800	[thread overview]
Message-ID: <1230689536.562.272.camel@rzhang-dt> (raw)
In-Reply-To: <1230633437.5328.13.camel@dax.rpnet.com>

On Tue, 2008-12-30 at 18:37 +0800, Richard Purdie wrote:
> On Wed, 2008-12-24 at 11:07 +0800, Zhang Rui wrote:
> > /sys/class/backlight/.../brightness returns a cached value,
> > which confuses a lot of users.
> > 
> > Make the "brightness" reflect the actual backlight levels,
> > and mark /sys/class/backlight/.../brightness as depreacated
> > in this patch.
> 
> This isn't an acceptable approach I'm afraid. We have some hardware
> which needs limiting of the backlight brightness in cases of low battery
we use "brightness" as the backlight limiting? then how does it work?
users can always set it to a higher or lower value no matter whether
it's low battery or not. IMO we'd better to use another file instead.
I got a couple of bugs about "the brightness file doesn't work", because
if people can change the backlight by poking "brightness", they prefer
to get the current brightness by reading it. what do you think?

> for example. "brightness" is the user requested value,
> "actual_brightness" is the one that is actually active.
why do we need the "user requested value"?
does some application depend on it?

thanks,
rui


  reply	other threads:[~2008-12-31  2:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24  3:07 [PATCH 2/2] video: mark "actual_brightness" deprecated Zhang Rui
2008-12-30 10:37 ` Richard Purdie
2008-12-31  2:12   ` Zhang Rui [this message]
2008-12-31 13:32     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1230689536.562.272.camel@rzhang-dt \
    --to=rui.zhang@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox