public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org, "Barnes,
	Jesse" <jesse.barnes@intel.com>,
	shaohua.li@intel.com
Subject: Re: ACPI hotplug panic with current git head
Date: Fri, 16 Jan 2009 09:19:06 -0500	[thread overview]
Message-ID: <1232115546.3224.5.camel@localhost.localdomain> (raw)
In-Reply-To: <4970242C.4010404@jp.fujitsu.com>

On Fri, 2009-01-16 at 15:07 +0900, Kenji Kaneshige wrote:
> > It looks like acpi_pci_get_bridge_handle() is returning NULL, so this is
> > the fix that works for me.
> > 
> 
> I'm sorry for troubling you, and thank you for your patience.
> 
> The patch seems to avoid the kernel panic, but I still don't know
> why acpi_pci_get_bridge_handle() returns NULL here. I assumed
> it should return non-NULL value here. So I'd like to investigate
> it more.

Sure, Len and I couldn't work out why it was returning NULL on this box
(other than that perhaps it doesn't have an ACPI entry).  The two
offending busses which trigger this are the two internal ones (which
aren't hotplug).  The layout of the box is:

sparkweed:~# lspci -t
-+-[0000:0c]---00.0
 +-[0000:0a]---00.0
 +-[0000:08]---00.0
 +-[0000:06]---00.0
 +-[0000:04]---00.0
 +-[0000:02]---00.0
 +-[0000:01]-+-00.0
 |           +-01.0
 |           +-01.1
 |           \-02.0
 \-[0000:00]-+-00.0
             +-01.0
             +-03.0
             +-03.1
             +-03.2
             +-0f.0
             +-0f.1
             \-0f.3
sparkweed:~# lspci   
00:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)
00:01.0 VGA compatible controller: ATI Technologies Inc Radeon RV100 QY
[Radeon 7000/VE]
00:03.0 USB Controller: NEC Corporation USB (rev 43)
00:03.1 USB Controller: NEC Corporation USB (rev 43)
00:03.2 USB Controller: NEC Corporation USB 2.0 (rev 04)
00:0f.0 Host bridge: Broadcom CSB6 South Bridge (rev a0)
00:0f.1 IDE interface: Broadcom CSB6 RAID/IDE Controller (rev a0)
00:0f.3 ISA bridge: Broadcom GCLE-2 Host Bridge
01:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)
01:01.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5704
Gigabit Ethernet (rev 10)
01:01.1 Ethernet controller: Broadcom Corporation NetXtreme BCM5704
Gigabit Ethernet (rev 10)
01:02.0 SCSI storage controller: Adaptec AIC-9410W SAS (Razor ASIC
non-RAID) (rev 08)
02:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)
04:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)
06:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)
08:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)
0a:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)
0c:00.0 Host bridge: IBM Calgary PCI-X Host Bridge (rev 02)

And when I annotate the problem, the two busses returning NULL are
0000:00 and 0000:01

James

  reply	other threads:[~2009-01-16 14:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-10 16:17 ACPI hotplug panic with current git head James Bottomley
2009-01-12 21:16 ` Len Brown
2009-01-13  0:48   ` James Bottomley
2009-01-13  3:40     ` Len Brown
2009-01-15 19:01     ` James Bottomley
2009-01-15 19:22       ` Len Brown
2009-01-15 19:54         ` James Bottomley
2009-01-15 20:12           ` James Bottomley
2009-01-16  6:07             ` Kenji Kaneshige
2009-01-16 14:19               ` James Bottomley [this message]
2009-01-19  1:10                 ` Kenji Kaneshige
2009-01-19  1:23                   ` James Bottomley
2009-01-19  3:11                     ` Kenji Kaneshige
2009-01-21 17:26                       ` James Bottomley
2009-01-26  2:11                         ` Kenji Kaneshige
2009-01-26  6:21                           ` Grant Grundler
2009-01-26 12:27                             ` Kenji Kaneshige
2009-01-28 11:47                           ` Kenji Kaneshige
2009-01-28 11:48                             ` [PATCH 1/8] PCI/ACPI: fix wrong assumption in acpi_pci_get_bridge_handle Kenji Kaneshige
2009-01-28 11:50                             ` [PATCH 2/8] PCI/ACPI: fix wrong assumption in acpi_find_root_bridge_handle Kenji Kaneshige
2009-01-28 11:51                             ` [PATCH 3/8] PCI hotplug: fix wrong assumption in acpi_get_hp_params_from_firmware Kenji Kaneshige
2009-01-28 11:55                             ` [PATCH 4/8] PCI hotplug: fix wrong assumption in acpi_get_hp_hw_control_from_firmware Kenji Kaneshige
2009-01-28 11:56                             ` [PATCH 5/8] PCI: fix wrong assumption in pci_find_upstream_pcie_bridge Kenji Kaneshige
2009-01-28 11:57                             ` [PATCH 6/8] PCI: fix wrong assumption in pci_read_bridge_bases Kenji Kaneshige
2009-01-28 11:58                             ` [PATCH 7/8] PCI: fix wrong assumption in pci_get_interrupt_pin Kenji Kaneshige
2009-01-28 11:59                             ` [PATCH 8/8] PCI: fix wrong assumption in pci_common_swizzle Kenji Kaneshige
2009-01-28 12:05                             ` ACPI hotplug panic with current git head Kenji Kaneshige
2009-02-14  0:30                             ` Jesse Barnes
2009-01-16 20:08               ` Len Brown
2009-01-16 20:22                 ` Jesse Barnes
2009-01-19  1:15                 ` Kenji Kaneshige

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232115546.3224.5.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=jesse.barnes@intel.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox