From: yakui_zhao <yakui.zhao@intel.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 0/2]: the patch set to weaken the dependency between ACPI video driver and i915 driver
Date: Thu, 16 Apr 2009 09:15:31 +0800 [thread overview]
Message-ID: <1239844531.3638.14.camel@localhost.localdomain> (raw)
In-Reply-To: <20090415165409.GB27807@srcf.ucam.org>
On Thu, 2009-04-16 at 00:54 +0800, Matthew Garrett wrote:
> Sorry, I should have been clearer. ACPI is required if the hardware
> supports opregion. Now that I've thought about it more, I think the
> patch I've just sent should remove the need to change the #ifdefs in
> the
> video driver
Agree. If another patch from you is applied, it is unnecessary to
change the #ifdef in the acpi video driver.
Please go ahead. Thanks.
Another issue is about the ACPI opregion. For the boxes that supports
ACPI opregion the brightness still can't be controlled even when the
acpi video driver is loaded correctly. Only after the i915 driver is
loaded, the ACPI backlight I/F can work well. In such case whether the
ACPI video driver can work well depends on the i915 driver.
But whether the i915 driver can work well doesn't depend on the acpi
video driver. Right?
At the same time a lot of people complain fail in the kernel compilation
if the i915 is compiled as builtin module and acpi video is compiled as
module.
So we had better make some changes so that there is no failure about
kernel compilation.
thanks.
next prev parent reply other threads:[~2009-04-16 1:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 3:04 [PATCH 0/2]: the patch set to weaken the dependency between ACPI video driver and i915 driver yakui_zhao
2009-04-14 19:35 ` Matthew Garrett
2009-04-15 1:12 ` yakui_zhao
2009-04-15 4:53 ` Matthew Garrett
2009-04-15 13:21 ` Zhao, Yakui
2009-04-15 16:54 ` Matthew Garrett
2009-04-16 1:15 ` yakui_zhao [this message]
2009-04-15 7:35 ` Zhang Rui
2009-04-15 20:56 ` Matthew Garrett
2009-04-23 19:56 ` Len Brown
2009-04-30 20:23 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239844531.3638.14.camel@localhost.localdomain \
--to=yakui.zhao@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox