From: yakui_zhao <yakui.zhao@intel.com>
To: Witold Szczeponik <Witold.Szczeponik@gmx.net>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Len Brown <lenb@kernel.org>, Bjorn Helgaas <bjorn.helgaas@hp.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"cedric@belbone.be" <cedric@belbone.be>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: suspend: don't let device _PS3 failure prevent suspend
Date: Mon, 11 May 2009 10:43:02 +0800 [thread overview]
Message-ID: <1242009782.3773.139.camel@localhost.localdomain> (raw)
In-Reply-To: <4A073D92.5060904@gmx.net>
On Mon, 2009-05-11 at 04:48 +0800, Witold Szczeponik wrote:
> Henrique de Moraes Holschuh schrieb:
>
> > On Fri, 08 May 2009, Len Brown wrote:
> >> Or perhaps we should just shrug off the _PS3 failure
> >> and carry on with _DIS like we used to -- which is
> >> what this patch does.
> >
> > Maybe "printk and carry on" would be better?
> >
>
> And there is very similar code just a few lines above: where we turn on
> the device by setting it to D0. There, too, we may want to skip the
> check whether or not the transition was successful or not.
What you said is right.
It sounds reasonable that we skip the power state check while transiting
it to D0 state.
In fact the power state check can be skipped by adding the boot option
of "acpi.power_nocheck=1".
thanks.
>
> --- Witold
next prev parent reply other threads:[~2009-05-11 2:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-13243-10286@http.bugzilla.kernel.org/>
[not found] ` <20090505150138.92f3ecd6.akpm@linux-foundation.org>
[not found] ` <4A02000D.9030400@gmx.net>
[not found] ` <200905061616.36707.bjorn.helgaas@hp.com>
2009-05-07 1:43 ` [Bugme-new] [Bug 13243] New: regression from 2.6.29 : can't suspend on a compaq nc6000, suspend_device(): pnp_bus_suspend+0x0/0x6b returns -5 yakui_zhao
2009-05-07 19:05 ` Witold Szczeponik
2009-05-08 1:31 ` yakui_zhao
2009-05-08 4:39 ` [PATCH] ACPI: suspend: don't let device _PS3 failure prevent suspend Len Brown
2009-05-08 12:23 ` Henrique de Moraes Holschuh
2009-05-10 20:48 ` Witold Szczeponik
2009-05-11 2:43 ` yakui_zhao [this message]
2009-05-11 15:21 ` Rafael J. Wysocki
2009-05-12 0:48 ` yakui_zhao
2009-05-12 2:01 ` Matthew Garrett
2009-05-12 2:26 ` yakui_zhao
2009-05-12 2:50 ` Matthew Garrett
2009-05-12 3:06 ` yakui_zhao
2009-05-12 4:11 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242009782.3773.139.camel@localhost.localdomain \
--to=yakui.zhao@intel.com \
--cc=Witold.Szczeponik@gmx.net \
--cc=bjorn.helgaas@hp.com \
--cc=cedric@belbone.be \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox