Linux ACPI
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Zhao, Yakui" <yakui.zhao@intel.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [RFC] i915/acpi: add lid status notification and detection
Date: Thu, 21 May 2009 16:57:53 +0800	[thread overview]
Message-ID: <1242896273.32574.10.camel@rzhang-dt> (raw)
In-Reply-To: <20090519171545.GA17801@srcf.ucam.org>

On Wed, 2009-05-20 at 01:15 +0800, Matthew Garrett wrote:
> > > There's also a policy question here.  On some machines, a lid close
> > > will cause the ACPI firmware to program the GPU, disabling the pipe
> > > associated with the panel.  Should we detect this and turn it back on
> > > at open time?  That could be dangerous if userspace has received the
> > > LVDS hotplug event and changed the config out from under us...
> > > 
> > > Comments?
> > It seems that the LID status is used to determine whether the LVDS is
> > connected.
> > It is not reliable. On some boxes the initial LID status is incorrect.
> > Maybe the LID status is open. But the ACPI returns that the LID is
> > close. In such case the LVDS is not initialized and user can't get the
> > output.
> 
> Really? I haven't seen any cases of this. They'll fail in all sorts of 
> fun ways with modern userland.
> 
This is rare, and if this happens, a bug should be filed against ACPI.
BTW: we have fixed/root caused all such kind of bugs that have been
reported.
So I think it makes sense to trust the Lid state reported by ACPI button
driver.

thanks,
rui


  reply	other threads:[~2009-05-21  8:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13 18:57 [RFC] i915/acpi: add lid status notification and detection Jesse Barnes
2009-05-14  1:22 ` yakui_zhao
2009-05-15 18:16   ` [PATCH] " Jesse Barnes
2009-05-19 17:15   ` [RFC] " Matthew Garrett
2009-05-21  8:57     ` Zhang Rui [this message]
2009-05-21 16:34       ` Jesse Barnes
2009-05-22  1:22         ` [Intel-gfx] " Fu Michael
2009-05-22  1:26           ` Matthew Garrett
2009-05-22  2:03             ` Zhang Rui
2009-05-27  8:58           ` Jesse Barnes
2009-05-27 13:41             ` Fu Michael
2009-06-11  7:16             ` yakui_zhao
2009-06-16 18:33               ` Jesse Barnes
2009-06-16 19:08                 ` Corentin Chary
2009-06-17  2:32                 ` yakui_zhao
2009-06-17 23:10                   ` Jesse Barnes
2009-07-07 22:51                     ` Jesse Barnes
2009-06-18 15:49                 ` Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242896273.32574.10.camel@rzhang-dt \
    --to=rui.zhang@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox