Re: [RFC] [PATCH]: ACPI: Rename ACPI processor device bus ID

Henrique de Moraes Holschuh
2009-05-23T03:18:13Z

On Thu, 21 May 2009, yakui_zhao wrote:
> + sprintf(acpi_device_bid(device), "CPU%X", pr->id);

Is this safe against overflows, i.e. is pr->id something *we* set? Because
if it is in any way read from the ACPI firmware, you have to either use
snprintf, or use the format string to limit the %X to a safe lenght...

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh