Re: [Resend] [PATCH]: ACPI: Rename ACPI processor device bus ID

[yakui_zhao <yakui.zhao@intel.com>]

On Sat, 2009-06-06 at 09:51 +0800, Len Brown wrote:
> We've promised to delete /proc/acpi instead of enhance it,
> so i'd rather see a patch that ignores errors from procfs
> and registers the driver even when procfs fails.
The issue can also be fixed by deleting the ACPI processor proc I/F.
I will send a patch that depreciated the ACPI processor proc I/F. 
When the CONFIG_ACPI_PROCFS is unset in kernel configuration, the
processor proc I/F won't be created.
thanks.

> thanks,
> Len Brown, Intel Open Source Technology Center
> 
> On Sun, 31 May 2009, yakui_zhao wrote:
> 
> > From: Zhao Yakui <yakui.zhao@intel.com
> > 
> > On some boxes several processors use the same processor bus id.
> > But they are located in different scope. For example:
> > 	\_SB.SCK0.CPU0
> > 	\_SB.SCK1.CPU0
> > 	As they use the same bus id, it can't be registered when
> > registering proc I/F. It causes that the ACPI processor driver can't
> > be bound with the processor device.
> > 	
> > Rename the processor device bus id. And the new bus id will be 
> > generated as the following format:
> > 	CPU+ CPU ID
> > 	
> > For example: If the cpu ID is 5, then the bus ID will be "CPU5".
> > 	If the CPU ID is 10, then the bus ID will be "CPUA".
> > 
> > Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> > ---
> >  drivers/acpi/processor_core.c |   11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > Index: linux-2.6/drivers/acpi/processor_core.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/acpi/processor_core.c	2009-05-27 08:38:44.000000000 +0800
> > +++ linux-2.6/drivers/acpi/processor_core.c	2009-05-31 10:21:21.000000000 +0800
> > @@ -649,7 +649,16 @@
> >  			return -ENODEV;
> >  		}
> >  	}
> > -
> > +	/*
> > +	 * On some boxes several processors use the same processor bus id.
> > +	 * But they are located in different scope. For example:
> > +	 * \_SB.SCK0.CPU0
> > +	 * \_SB.SCK1.CPU0
> > +	 * Rename the processor device bus id. And the new bus id will be
> > +	 * generated as the following format:
> > +	 * CPU+CPU ID.
> > +	 */
> > +	sprintf(acpi_device_bid(device), "CPU%X", pr->id);
> >  	ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Processor [%d:%d]\n", pr->id,
> >  			  pr->acpi_id));
> >  
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >