From mboxrd@z Thu Jan 1 00:00:00 1970 From: yakui_zhao Subject: Re: [Resend] [PATCH]: ACPI: Rename ACPI processor device bus ID Date: Mon, 08 Jun 2009 16:03:09 +0800 Message-ID: <1244448189.3636.27.camel@localhost.localdomain> References: <1243737111.3634.168.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:11152 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbZFHIBy (ORCPT ); Mon, 8 Jun 2009 04:01:54 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: "linux-acpi@vger.kernel.org" On Sat, 2009-06-06 at 09:51 +0800, Len Brown wrote: > We've promised to delete /proc/acpi instead of enhance it, > so i'd rather see a patch that ignores errors from procfs > and registers the driver even when procfs fails. The issue can also be fixed by deleting the ACPI processor proc I/F. I will send a patch that depreciated the ACPI processor proc I/F. When the CONFIG_ACPI_PROCFS is unset in kernel configuration, the processor proc I/F won't be created. thanks. > thanks, > Len Brown, Intel Open Source Technology Center > > On Sun, 31 May 2009, yakui_zhao wrote: > > > From: Zhao Yakui > > > On some boxes several processors use the same processor bus id. > > But they are located in different scope. For example: > > \_SB.SCK0.CPU0 > > \_SB.SCK1.CPU0 > > As they use the same bus id, it can't be registered when > > registering proc I/F. It causes that the ACPI processor driver can't > > be bound with the processor device. > > > > Rename the processor device bus id. And the new bus id will be > > generated as the following format: > > CPU+ CPU ID > > > > For example: If the cpu ID is 5, then the bus ID will be "CPU5". > > If the CPU ID is 10, then the bus ID will be "CPUA". > > > > Signed-off-by: Zhao Yakui > > --- > > drivers/acpi/processor_core.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > Index: linux-2.6/drivers/acpi/processor_core.c > > =================================================================== > > --- linux-2.6.orig/drivers/acpi/processor_core.c 2009-05-27 08:38:44.000000000 +0800 > > +++ linux-2.6/drivers/acpi/processor_core.c 2009-05-31 10:21:21.000000000 +0800 > > @@ -649,7 +649,16 @@ > > return -ENODEV; > > } > > } > > - > > + /* > > + * On some boxes several processors use the same processor bus id. > > + * But they are located in different scope. For example: > > + * \_SB.SCK0.CPU0 > > + * \_SB.SCK1.CPU0 > > + * Rename the processor device bus id. And the new bus id will be > > + * generated as the following format: > > + * CPU+CPU ID. > > + */ > > + sprintf(acpi_device_bid(device), "CPU%X", pr->id); > > ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Processor [%d:%d]\n", pr->id, > > pr->acpi_id)); > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >