Re: [PATCH] sony-laptop: no need to unblock rfkill on load

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On Mon, 2009-06-08 at 11:31 +0100, Alan Jenkins wrote:
> The re-written rfkill core ensures rfkill devices are initialized to
> the system default state.  The core calls set_block after registration
> so the driver shouldn't need to.
> 
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

Good catch, thanks.

> ---
> 
> This patch applies on top of the rfkill rewrite in the wireless-testing tree.
> 
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index aec0b27..c1b21a4 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -1114,7 +1114,6 @@ static int sony_nc_setup_rfkill(struct acpi_device *device,
>  		return err;
>  	}
>  	sony_rfkill_devices[nc_type] = rfk;
> -	sony_nc_rfkill_set((void *)nc_type, false);
>  	return err;
>  }
>  
> 
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]