From: yakui_zhao <yakui.zhao@intel.com>
To: "Alexander E. Patrakov" <patrakov@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Zhang, Rui" <rui.zhang@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [Intel-gfx] RFC] [Patch] [DRM/I915] :Check the LID device to decide whether the LVDS should be initialized
Date: Mon, 15 Jun 2009 15:41:10 +0800 [thread overview]
Message-ID: <1245051670.3583.35.camel@localhost.localdomain> (raw)
In-Reply-To: <c072ca310906122248w62683eb4waad8fd0be49b20@mail.gmail.com>
On Sat, 2009-06-13 at 13:48 +0800, Alexander E. Patrakov wrote:
> 2009/6/11 yakui_zhao <yakui.zhao@intel.com>:
> > + if (acpi_disabled) {
> > + /*
> > + * if ACPI is disabled, there is no ACPI device tree. And
> > + * we don't know whether there exists the LID device.
> > + * In such case we will return 0.
> > + */
> > + return 0;
> > + }
>
> Won't this prevent people from debugging ACPI problems on laptops by
> disabling ACPI on the kernel command line? Does this patch mean that,
> in such case, there will be no output at all? Maybe, without ACPI, we
> should initialize LVDS if and only if there are no other output
> devices connected?
No. It has no effect on LVDS output device if ACPI is disabled.
If the system is booted with acpi disabled, the function of intel_lvds_find_lid
will return zero and it will continue the current flowchart of LVDS output device.
Thanks.
prev parent reply other threads:[~2009-06-15 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1244187921.3558.223.camel@localhost.localdomain>
[not found] ` <1244200261.11142.20.camel@gaiman.anholt.net>
[not found] ` <1244422347.3698.6.camel@localhost.localdomain>
[not found] ` <1244585813.4896.34.camel@gaiman.anholt.net>
[not found] ` <20090609153559.2e93479d@jbarnes-x200>
[not found] ` <1244714614.3618.10.camel@localhost.localdomain>
2009-06-12 1:00 ` [Intel-gfx] RFC] [Patch] [DRM/I915] :Check the LID device to decide whether the LVDS should be initialized yakui_zhao
2009-06-15 18:33 ` Vladimir 'phcoder' Serbinenko
2009-06-16 3:31 ` yakui_zhao
2009-06-16 10:59 ` Vladimir 'phcoder' Serbinenko
2009-06-18 6:27 ` yakui_zhao
2009-06-13 5:48 ` Alexander E. Patrakov
2009-06-13 5:50 ` Alexander E. Patrakov
2009-06-15 7:41 ` yakui_zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245051670.3583.35.camel@localhost.localdomain \
--to=yakui.zhao@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=patrakov@gmail.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox