Re: [Intel-gfx] RFC] [Patch] [DRM/I915] :Check the LID device to decide whether the LVDS should be initialized

yakui_zhao
2009-06-15T07:39:58Z

On Sat, 2009-06-13 at 13:48 +0800, Alexander E. Patrakov wrote:
> 2009/6/11 yakui_zhao <yakui.zhao@intel.com>:
> > + if (acpi_disabled) {
> > + /*
> > + * if ACPI is disabled, there is no ACPI device tree. And
> > + * we don't know whether there exists the LID device.
> > + * In such case we will return 0.
> > + */
> > + return 0;
> > + }
>
> Won't this prevent people from debugging ACPI problems on laptops by
> disabling ACPI on the kernel command line? Does this patch mean that,
> in such case, there will be no output at all? Maybe, without ACPI, we
> should initialize LVDS if and only if there are no other output
> devices connected?
No. It has no effect on LVDS output device if ACPI is disabled.
If the system is booted with acpi disabled, the function of intel_lvds_find_lid
will return zero and it will continue the current flowchart of LVDS output device.

Thanks.