Re: [Intel-gfx] RFC] [Patch] [DRM/I915] :Check the LID device to decide whether the LVDS should be initialized

Alexander E. Patrakov
2009-06-13T05:50:23Z

2009/6/13 Alexander E. Patrakov <patrakov@gmail.com>:
> 2009/6/11 yakui_zhao <yakui.zhao@intel.com>:
>> +       if (acpi_disabled) {
>> +               /*
>> +                * if ACPI is disabled, there is no ACPI device tree. And
>> +                * we don't know whether there exists the LID device.
>> +                * In such case we will return 0.
>> +                */
>> +               return 0;
>> +       }
>
> Won't this prevent people from debugging ACPI problems on laptops by
> disabling ACPI on the kernel command line? Does this patch mean that,
> in such case, there will be no output at all? Maybe, without ACPI, we
> should initialize LVDS if and only if there are no other output
> devices connected?

Oops, I misread the code. If ACPI is disabled, we return 0, not
-ENODEV. That's right.

--
Alexander E. Patrakov