Re: [PATCH 0/3] Generic sysfs support for ACPI ALS and other ALS devices

Valdis.Kletnieks
2009-08-05T16:11:45Z

[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]

On Wed, 05 Aug 2009 09:04:52 +0800, Zhang Rui said:
> On Wed, 2009-08-05 at 01:36 +0800, Greg KH wrote:
> > On Tue, Aug 04, 2009 at 01:24:24PM -0400, Valdis.Kletnieks@vt.edu wrote:
> > > On Tue, 04 Aug 2009 08:10:42 PDT, Greg KH said:
> > > > On Tue, Aug 04, 2009 at 03:21:29PM +0200, Pavel Machek wrote:
> > > > > On Mon 2009-08-03 17:10:57, Zhang Rui wrote:
> > >
> > > > > > cat /sys/class/als/als0/mappings
> > > > > > ???Illuminance Adjustment
> > > > > > 0 70
> > > > > > 10 73
> > > > > > 80 85
> > > > > > 300 100
> > > > > > 1000 150
> > > > >
> > > > > There's one value per file for sysfs... You should definitely have th
e
> > > > > header.
> > > >
> > > > No, no "header", just don't do this, it's not allowed. Again,
> > > > one-value-per-sysfs-file is the rule, please do not violate it.
> > >
> > > What's the intended sysfs solution here, then? Make 'mappings' a directory,
> > > and populate it with files called 0, 10, 80, 300, 1000, each with one number
> > > in them?
> >
> > That's one acceptable solution. Or how about files in this directory
> > called "mapping_0", "mapping_10", and so on, containing the adjustment
> > value?
> >
> great. that's what I'm going to do.
> refreshed patch will be sent out later. :)

Hmm. whether to call the files mapping_0, mapping_10 etc or mapping/0, mapping/10
etc probably depends on how nailed-down the 0,10,80,300,100 is - are those
numbers carved in stone, or are we better off defining the API as "directory
mapping, and files for whatever values the hardware happens to cough up?"

Not a biggie either way, it's going to be a readdir()/filter/open()/close()
loop either way, just different details for the readdir() and entry filtering...

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]