ACPICA Release 20090730 linuxized patches

ACPICA Release 20090730 linuxized patches

[Lin Ming]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

Hi, Len

ACPICA Release 20090730 linuxized patches attached.
Build&Test on 32&64 bit machines.

Applied cleanly on top of linux-acpi-2.6/test branch.

Lin Ming
---
[PATCH 01/13] ACPICA: Move predefined repair code to new file, no functional change
[PATCH 02/13] ACPICA: Add repair for predefined methods that return nested packages
[PATCH 03/13] ACPICA: ACPI 4.0 : Add new return package type, restructure module.
[PATCH 04/13] ACPICA: Fix fault if acpi_terminate is called twice
[PATCH 05/13] ACPICA: Split large ACPI table header
[PATCH 06/13] ACPICA: ACPI 4: Update headers for new and changed ACPI tables.
[PATCH 07/13] ACPICA: reformat predefined method table, no functional change
[PATCH 08/13] ACPICA: ACPI 4: Add validation for new predefined names.
[PATCH 09/13] ACPICA: Add support for module-level executable AML code
[PATCH 10/13] ACPICA: Update definitions for HEST table
[PATCH 11/13] ACPICA: Fix typo for HEST ACPI table
[PATCH 12/13] ACPICA: acpi_reset: Bypass port validation mechanism
[PATCH 13/13] ACPICA: Update version to 20090730

[-- Attachment #2: acpica-v20090730.mbox.tar.bz2 --]
[-- Type: application/x-bzip-compressed-tar, Size: 29083 bytes --]

Re: ACPICA Release 20090730 linuxized patches

[Len Brown]

On Fri, 14 Aug 2009, Lin Ming wrote:

> Hi, Len
> 
> ACPICA Release 20090730 linuxized patches attached.
> Build&Test on 32&64 bit machines.
> 
> Applied cleanly on top of linux-acpi-2.6/test branch.
> 
> Lin Ming
> ---
> [PATCH 01/13] ACPICA: Move predefined repair code to new file, no functional change
> [PATCH 02/13] ACPICA: Add repair for predefined methods that return nested packages
> [PATCH 03/13] ACPICA: ACPI 4.0 : Add new return package type, restructure module.
> [PATCH 04/13] ACPICA: Fix fault if acpi_terminate is called twice
> [PATCH 05/13] ACPICA: Split large ACPI table header
> [PATCH 06/13] ACPICA: ACPI 4: Update headers for new and changed ACPI tables.
> [PATCH 07/13] ACPICA: reformat predefined method table, no functional change
> [PATCH 08/13] ACPICA: ACPI 4: Add validation for new predefined names.
> [PATCH 09/13] ACPICA: Add support for module-level executable AML code
> [PATCH 10/13] ACPICA: Update definitions for HEST table
> [PATCH 11/13] ACPICA: Fix typo for HEST ACPI table
> [PATCH 12/13] ACPICA: acpi_reset: Bypass port validation mechanism
> [PATCH 13/13] ACPICA: Update version to 20090730

thanks for the port, Lin-Ming.

checkpatch.pl, as usual, is not happy:

total: 389 errors, 103 warnings, 4771 lines checked

someday we need to address these formatting issues...


thanks,
Len Brown, Intel Open Source Technology Center

Re: ACPICA Release 20090730 linuxized patches

[Len Brown]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 773 bytes --]

On Fri, 14 Aug 2009, Lin Ming wrote:

> Hi, Len
> 
> ACPICA Release 20090730 linuxized patches attached.
> Build&Test on 32&64 bit machines.

please build with CONFIG_DMAR=y

  CC      drivers/pci/dmar.o
drivers/pci/dmar.c: In function ‘dmar_parse_one_dev_scope’:
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member 
named ‘dev’
drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member 
named ‘fn’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member 
named ‘dev’
drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member 
named ‘fn’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member 
named ‘dev’
drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member 
named ‘fn’

Re: ACPICA Release 20090730 linuxized patches

[Lin Ming]

On Sat, 2009-08-15 at 11:30 +0800, Len Brown wrote:
> On Fri, 14 Aug 2009, Lin Ming wrote:
> 
> > Hi, Len
> > 
> > ACPICA Release 20090730 linuxized patches attached.
> > Build&Test on 32&64 bit machines.
> > 
> > Applied cleanly on top of linux-acpi-2.6/test branch.
> > 
> > Lin Ming
> > ---
> > [PATCH 01/13] ACPICA: Move predefined repair code to new file, no functional change
> > [PATCH 02/13] ACPICA: Add repair for predefined methods that return nested packages
> > [PATCH 03/13] ACPICA: ACPI 4.0 : Add new return package type, restructure module.
> > [PATCH 04/13] ACPICA: Fix fault if acpi_terminate is called twice
> > [PATCH 05/13] ACPICA: Split large ACPI table header
> > [PATCH 06/13] ACPICA: ACPI 4: Update headers for new and changed ACPI tables.
> > [PATCH 07/13] ACPICA: reformat predefined method table, no functional change
> > [PATCH 08/13] ACPICA: ACPI 4: Add validation for new predefined names.
> > [PATCH 09/13] ACPICA: Add support for module-level executable AML code
> > [PATCH 10/13] ACPICA: Update definitions for HEST table
> > [PATCH 11/13] ACPICA: Fix typo for HEST ACPI table
> > [PATCH 12/13] ACPICA: acpi_reset: Bypass port validation mechanism
> > [PATCH 13/13] ACPICA: Update version to 20090730
> 
> thanks for the port, Lin-Ming.
> 
> checkpatch.pl, as usual, is not happy:
> 
> total: 389 errors, 103 warnings, 4771 lines checked

$checkpatch.pl acpica-v20090730.mbox | grep "ERROR:" | sort | uniq
ERROR: return is not a function, parentheses are not required
ERROR: space required after that close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '?' (ctx:VxE)

I think we don't need to fix these errors in order to decrease the gap
between ACPICA and linux-acpica code.

> 
> someday we need to address these formatting issues...

We need to document which error(s) need to be fixed.
Currently, only two errors are fixed.

ERROR: trailing whitespace
ERROR: code indent should use tabs where possible

Lin Ming

> 
> 
> thanks,
> Len Brown, Intel Open Source Technology Center
> 

Re: ACPICA Release 20090730 linuxized patches

[Lin Ming]

On Sat, 2009-08-15 at 11:33 +0800, Len Brown wrote:
> On Fri, 14 Aug 2009, Lin Ming wrote:
> 
> > Hi, Len
> > 
> > ACPICA Release 20090730 linuxized patches attached.
> > Build&Test on 32&64 bit machines.
> 
> please build with CONFIG_DMAR=y

Fix dmar build error.
Now build OK with "make allyesconfig"


diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
index 674e27b..6f3dce9 100644
--- a/include/acpi/actbl2.h
+++ b/include/acpi/actbl2.h
@@ -252,8 +252,8 @@ enum acpi_dmar_scope_type {
 };
 
 struct acpi_dmar_pci_path {
-	u8 device;
-	u8 function;
+	u8 dev;
+	u8 fn;
 };
 
 /*


> 
>   CC      drivers/pci/dmar.o
> drivers/pci/dmar.c: In function ‘dmar_parse_one_dev_scope’:
> drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member 
> named ‘dev’
> drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member 
> named ‘fn’
> drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member 
> named ‘dev’
> drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member 
> named ‘fn’
> drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member 
> named ‘dev’
> drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member 
> named ‘fn’

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ACPICA Release 20090730 linuxized patches

[Lin Ming]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

On Mon, 2009-08-17 at 10:06 +0800, Lin Ming wrote:
> On Sat, 2009-08-15 at 11:33 +0800, Len Brown wrote:
> > On Fri, 14 Aug 2009, Lin Ming wrote:
> > 
> > > Hi, Len
> > > 
> > > ACPICA Release 20090730 linuxized patches attached.
> > > Build&Test on 32&64 bit machines.
> > 
> > please build with CONFIG_DMAR=y
> 
> Fix dmar build error.
> Now build OK with "make allyesconfig"

New mbox file attached.

Lin Ming

> 
> 
> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
> index 674e27b..6f3dce9 100644
> --- a/include/acpi/actbl2.h
> +++ b/include/acpi/actbl2.h
> @@ -252,8 +252,8 @@ enum acpi_dmar_scope_type {
>  };
>  
>  struct acpi_dmar_pci_path {
> -	u8 device;
> -	u8 function;
> +	u8 dev;
> +	u8 fn;
>  };
>  
>  /*
> 
> 
> > 
> >   CC      drivers/pci/dmar.o
> > drivers/pci/dmar.c: In function ‘dmar_parse_one_dev_scope’:
> > drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member 
> > named ‘dev’
> > drivers/pci/dmar.c:87: error: ‘struct acpi_dmar_pci_path’ has no member 
> > named ‘fn’
> > drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member 
> > named ‘dev’
> > drivers/pci/dmar.c:91: error: ‘struct acpi_dmar_pci_path’ has no member 
> > named ‘fn’
> > drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member 
> > named ‘dev’
> > drivers/pci/dmar.c:101: error: ‘struct acpi_dmar_pci_path’ has no member 
> > named ‘fn’

[-- Attachment #2: acpica-v20090730+dmar_build_fix.mbox.tar.bz2 --]
[-- Type: application/x-bzip-compressed-tar, Size: 29099 bytes --]

Re: ACPICA Release 20090730 linuxized patches

[Len Brown]

> New mbox file attached.

applied.

thanks,
Len Brown, Intel Open Source Technology Center