From: Marcel Holtmann <marcel@holtmann.org>
To: Alan Jenkins <sourcejedi.lkml@googlemail.com>
Cc: Mario Limonciello <mario_limonciello@dell.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
cezary.jackiewicz@gmail.com
Subject: Re: [PATCH 3/3] Drop platform sysfs support
Date: Tue, 18 Aug 2009 02:54:45 -0700 [thread overview]
Message-ID: <1250589285.5150.1.camel@localhost.localdomain> (raw)
In-Reply-To: <9b2b86520908180143t4b25c1f7hd78cd4b4333c4ab4@mail.gmail.com>
Hi Alan,
> > With rfkill support being added, the platform support is no longer
> > necessary. Standard rfkill interfaces can be used to administer the box
> > now.
> > --
> > Mario Limonciello
> > *Dell | Linux Engineering*
> > mario_limonciello@dell.com
> >
>
> -static struct platform_device *compal_device;
>
> I don't think this is the right way to go. I don't object to removing
> the sysfs attributes, but the platform device can still be useful as a
> parent device to the rfkill and backlight devices. (See my earlier
> comment on the use of rfkill_allocate()).
>
> In practice I suspect it makes no difference that the rfkill and
> backlight devices are exported as virtual devices with no physical
> parent. I just don't think it's "right" :-).
it actually does make a difference for hardware detection. We wanna have
them hanging of the compal platform device.
Regards
Marcel
next prev parent reply other threads:[~2009-08-18 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 23:27 [PATCH 3/3] Drop platform sysfs support Mario Limonciello
2009-08-18 8:43 ` Alan Jenkins
2009-08-18 9:54 ` Marcel Holtmann [this message]
2009-08-18 13:23 ` Alan Jenkins
2009-08-18 17:48 ` Mario Limonciello
2009-08-18 21:45 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250589285.5150.1.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=cezary.jackiewicz@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox