From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: [PATCH 3/3] Drop platform sysfs support Date: Tue, 18 Aug 2009 14:45:34 -0700 Message-ID: <1250631934.5150.3.camel@localhost.localdomain> References: <4A89E76B.5070204@dell.com> <9b2b86520908180143t4b25c1f7hd78cd4b4333c4ab4@mail.gmail.com> <1250589285.5150.1.camel@localhost.localdomain> <9b2b86520908180623i4e7ce5cv9a4cd6b1704a0e5f@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from senator.holtmann.net ([87.106.208.187]:35583 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbZHRVqI (ORCPT ); Tue, 18 Aug 2009 17:46:08 -0400 In-Reply-To: <9b2b86520908180623i4e7ce5cv9a4cd6b1704a0e5f@mail.gmail.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alan Jenkins Cc: Mario Limonciello , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, cezary.jackiewicz@gmail.com Hi Alan, > >> In practice I suspect it makes no difference that the rfkill and > >> backlight devices are exported as virtual devices with no physical > >> parent. I just don't think it's "right" :-). > > > > it actually does make a difference for hardware detection. We wanna have > > them hanging of the compal platform device. > > Ok. I wasn't sure that userspace was allowed to rely on that, but I > re-read Documentation/ABI/testing/sysfs-devices and I see now that it > can be allowed. > > Some of these issues with the compal-laptop work may come from copying > dell-laptop. dell-laptop is the only driver which creates rfkill > devices without a parent device. In fact, it doesn't even create a > platform device :-). then that should be fixed. All RFKILL switches should really have a parent and not dangling around the virtual tree. Especially since they have physical hardware in the system. > I'll try sending a patch or two to clean up dell-laptop. I don't have > the hardware but it should be pretty mechanical, almost a copy+paste > job from a "good" driver. That would be good. I don't have the hardware either, but others here can test it. Regards Marcel