From: Johannes Berg <johannes@sipsolutions.net>
To: Mario Limonciello <Mario_Limonciello@Dell.com>
Cc: cezary.jackiewicz@gmail.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] Add rfkill support to compal-laptop
Date: Wed, 19 Aug 2009 20:42:56 +0200 [thread overview]
Message-ID: <1250707376.8073.4.camel@johannes.local> (raw)
In-Reply-To: <1250706969-10382-1-git-send-email-Mario_Limonciello@Dell.com>
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On Wed, 2009-08-19 at 13:36 -0500, Mario Limonciello wrote:
> Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com>
> Reviewed-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> + ret = setup_rfkill();
> + if (ret)
> + goto fail_rfkill;
> +
> printk(KERN_INFO "compal-laptop: driver "COMPAL_DRIVER_VERSION
> " successfully loaded.\n");
>
> return 0;
>
> +fail_rfkill:
> fail_platform_device2:
Isn't that missing sysfs_remove_group()?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-08-19 18:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 18:36 [PATCH 2/3] Add rfkill support to compal-laptop Mario Limonciello
2009-08-19 18:42 ` Johannes Berg [this message]
2009-08-19 18:47 ` Mario Limonciello
2009-08-20 8:52 ` Alan Jenkins
2009-08-21 21:39 ` [PATCH] compal-laptop: Replace sysfs support with rfkill support Mario Limonciello
2009-08-22 11:20 ` Alan Jenkins
[not found] ` <9b2b86520908220420p282c862fn9c44697db010a08d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-24 19:50 ` Mario Limonciello
2009-08-25 8:15 ` Alan Jenkins
-- strict thread matches above, loose matches on Subject: below --
2009-08-17 23:27 [PATCH 2/3] Add rfkill support to compal-laptop Mario Limonciello
2009-08-18 1:24 ` Marcel Holtmann
2009-08-18 7:44 ` Alan Jenkins
2009-08-18 14:52 ` Alan Jenkins
2009-08-18 17:26 ` Mario Limonciello
2009-08-18 21:08 ` Alan Jenkins
[not found] ` <9b2b86520908181408v5f7875b6sea31d8d95cc08c0b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-08-18 21:31 ` Johannes Berg
2009-08-18 22:00 ` Mario Limonciello
2009-08-19 8:51 ` Alan Jenkins
2009-08-19 9:01 ` Johannes Berg
2009-08-19 11:43 ` Cezary Jackiewicz
[not found] ` <1250672475.25419.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-08-19 16:46 ` Mario Limonciello
2009-08-19 16:57 ` Alan Jenkins
2009-08-19 17:13 ` Johannes Berg
2009-08-19 18:39 ` Mario Limonciello
2009-08-18 21:17 ` Alan Jenkins
2009-08-18 8:33 ` Alan Jenkins
2009-08-18 8:19 ` Alan Jenkins
2009-08-18 12:22 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250707376.8073.4.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=Mario_Limonciello@Dell.com \
--cc=cezary.jackiewicz@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).