From: Zhang Rui <rui.zhang@intel.com>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>, Pavel Machek <pavel@ucw.cz>,
Len Brown <lenb@kernel.org>
Subject: Re: [RFC] [PATCH v3 1/2] introduce ALS sysfs class
Date: Tue, 25 Aug 2009 11:36:52 +0800 [thread overview]
Message-ID: <1251171412.3483.74.camel@rzhang-dt> (raw)
In-Reply-To: <20090821150825.GC10667@kroah.com>
On Fri, 2009-08-21 at 23:08 +0800, Greg KH wrote:
> On Fri, Aug 21, 2009 at 09:54:07AM +0800, Zhang Rui wrote:
> > ---
> > Documentation/ABI/testing/sysfs-class-als | 47 +++++
> > drivers/Kconfig | 2
> > drivers/Makefile | 1
> > drivers/als/Kconfig | 10 +
> > drivers/als/Makefile | 5
> > drivers/als/als_sys.c | 256 ++++++++++++++++++++++++++++++
> > include/linux/als_sys.h | 57 ++++++
>
> Does this file really need to be in include/linux/ ?
>
> Or could you just put it into drivers/als/ and it would be fine?
>
I don't think so, because all the other native ALS drivers like ACPI ALS
driver should depend on this header file.
thanks,
rui
prev parent reply other threads:[~2009-08-25 3:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 8:40 [RFC] [PATCH v3 1/2] introduce ALS sysfs class Zhang Rui
2009-08-19 8:57 ` Zhang Rui
2009-08-19 16:01 ` Greg KH
2009-08-21 1:54 ` Zhang Rui
2009-08-21 15:08 ` Greg KH
2009-08-25 3:36 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251171412.3483.74.camel@rzhang-dt \
--to=rui.zhang@intel.com \
--cc=bjorn.helgaas@hp.com \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox