From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [RFC][PATCH 2/2] disable boot interrupts on Intel X58 and 55x0 Date: Fri, 04 Sep 2009 10:06:59 -0700 Message-ID: <1252084019.22928.39.camel@desktop> References: <20090904165525.26294.31112.sendpatchset@t500> <20090904165545.26294.94612.sendpatchset@t500> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from fifo99.com ([67.223.236.141]:37021 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755130AbZIDRGx (ORCPT ); Fri, 4 Sep 2009 13:06:53 -0400 In-Reply-To: <20090904165545.26294.94612.sendpatchset@t500> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Stefan Assmann Cc: linux-kernel@vger.kernel.org, jcm@redhat.com, sdietrich@novell.com, linux-acpi@vger.kernel.org, andi@firstfloor.org, hpa@zytor.com, mingo@elte.hu, Olaf.Dabrunz@gmx.net, ktokunag@redhat.com, tglx@linutronix.de, lenb@kernel.org On Fri, 2009-09-04 at 12:55 -0400, Stefan Assmann wrote: > + * Disable boot interrupts on Intel X58, 55x0 (Tylersburg). > + * See Intel document #321328-001, section 19.10.2.27. > + * (Disable PCI INTx Routing to ICH) > + */ > +#define INTEL_X58_55x0_QPIPINTRC_OFFSET 0xe0 > +#define INTEL_X58_55x0_QPIPINTRC_BIT (1<<25) > +static void quirk_disable_intel_tylersburg_boot_interrupt(struct > pci_dev *dev) > +{ > + u32 pci_config_dword; > + > + if (noioapicquirk) > + return; > + > + pci_read_config_dword(dev, INTEL_X58_55x0_QPIPINTRC_OFFSET, > &pci_config_dword); > + pci_config_dword |= INTEL_X58_55x0_QPIPINTRC_BIT; > + pci_write_config_dword(dev, INTEL_X58_55x0_QPIPINTRC_OFFSET, > pci_config_dword); > + > + printk(KERN_INFO "disabled boot interrupt on device 0x%04x:0x% > 04x\n", > + dev->vendor, dev->device); > +} > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QPI_TBG15, quirk_disable_intel_tylersburg_boot_interrupt); > +DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QPI_TBG15, quirk_disable_intel_tylersburg_boot_interrupt); These lines are wildly long .. Could you reduce these down to a max of 80 characters.. Daniel