From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Subject: Re: [PATCH 3/3] ACPI: battery: register power_supply subdevice even when battery not present Date: Mon, 07 Sep 2009 05:37:07 +0300 Message-ID: <1252291027.4627.2.camel@maxim-laptop> References: <4A098D0A.6090509@tuffmail.co.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from fg-out-1718.google.com ([72.14.220.152]:31124 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbZIGChL (ORCPT ); Sun, 6 Sep 2009 22:37:11 -0400 Received: by fg-out-1718.google.com with SMTP id 22so1571283fge.1 for ; Sun, 06 Sep 2009 19:37:13 -0700 (PDT) In-Reply-To: <4A098D0A.6090509@tuffmail.co.uk> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alan Jenkins Cc: linux acpi , Alexey Starikovskiy On Tue, 2009-05-12 at 15:51 +0100, Alan Jenkins wrote: > Keeping this device around lets userspace know that we have a battery > bay, even if there is nothing in it at the moment. This is what every > other battery driver does, so ACPI should do it as well. > > There is no reason to preserve the old behaviour. We now correctly > provide the "present" attribute, which will return "0" when the battery > is removed. HAL was already trying to check this attribute, so > it should be fine. > > Signed-off-by: Alan Jenkins What happened to this patch? I still get the issue this patch attempts to fix: maxim@maxim-laptop:~/software/kernel/linux-2.6$ ls /sys/class/power_supply/ AC maxim@maxim-laptop:~/software/kernel/linux-2.6$ ls /sys/class/power_supply/ AC BAT0 maxim@maxim-laptop:~/software/kernel/linux-2.6$ ls /sys/class/power_supply/ AC maxim@maxim-laptop:~/software/kernel/linux-2.6$ uname -r 2.6.31-rc8-next-20090904-next maxim@maxim-laptop:~/software/kernel/linux-2.6$ When I unplug the battery, its sysfs entry disappears. Thus if system was booted without battery, there will be no way to know system has one. This patch doesn't apply. Best regards, Maxim Levitsky