From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>
Cc: Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>,
Jose Marino <braket-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>,
ACPI Devel Maling List
<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux PCI <linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Dominik Brodowski
<linux-X3ehHDuj6sIIGcDfoQAp7OTW4wlIGRCZ@public.gmane.org>
Subject: Re: Help needed, Re: [Bug #14334] pcmcia suspend regression from 2.6.31.1 to 2.6.31.2 - Dell Inspiron 600m
Date: Tue, 03 Nov 2009 09:22:03 +1100 [thread overview]
Message-ID: <1257200523.7907.53.camel@pasglop> (raw)
In-Reply-To: <200911021439.28266.rjw-KKrjLPT3xs0@public.gmane.org>
On Mon, 2009-11-02 at 14:39 +0100, Rafael J. Wysocki wrote:
>
> > That socket _is_ going to be suspended, and testing for it here just seems
> > to confuse things.
> >
> > So I'd remove it from both early_resume and late_resume, and only keep it
> > in the case of the legacy user-requested suspend/resume (do we even do
> > that any more?).
>
> OK, updated patch is appended.
Test by me delayed to tomorrow ... hit another suspend/resume bug on
that laptop which took away the time I had to do that test yesterday and
today I'm off :-)
(Bug was simple but took a while to track down: machine was left in
storage for a while, battery ran out, RTC went back to Jan 1, 1904,
which means a negative xtime, and the new timekeeping code will do
horrible things including hanging at resume when that happens. Fix is to
make powerpc read_persistent_clock() to ignore the RTC when it contains
a date older than epoch).
Cheers,
Ben.
next prev parent reply other threads:[~2009-11-02 22:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 18:45 2.6.32-rc5-git3: Reported regressions from 2.6.31 Rafael J. Wysocki
[not found] ` <6dRYo8ss7vL.A.Z4G.kre5KB@chimera>
[not found] ` <4AE5F563.5020803@gmail.com>
2009-10-26 19:30 ` [Bug #14379] ACPI Warning for _SB_.BAT0._BIF: Converted Buffer to expected String Rafael J. Wysocki
[not found] ` <6dRYo8ss7vL.A.hyE.2qe5KB@chimera>
[not found] ` <4AE601B1.7050000@gmail.com>
[not found] ` <4AE601B1.7050000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-10-26 21:01 ` [Bug #14483] WARNING: at drivers/base/sys.c:353 __sysdev_resume+0x54/0xca() Rafael J. Wysocki
[not found] ` <6dRYo8ss7vL.A.EqH.Nse5KB@chimera>
2009-10-30 18:48 ` Help needed, Re: [Bug #14334] pcmcia suspend regression from 2.6.31.1 to 2.6.31.2 - Dell Inspiron 600m Rafael J. Wysocki
2009-10-30 19:47 ` Linus Torvalds
2009-10-30 20:32 ` Rafael J. Wysocki
2009-10-30 20:40 ` Linus Torvalds
2009-10-30 21:17 ` Linus Torvalds
[not found] ` <alpine.LFD.2.01.0910301412500.31845-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-10-30 22:17 ` Rafael J. Wysocki
2009-10-30 23:54 ` Benjamin Herrenschmidt
2009-10-30 23:57 ` Benjamin Herrenschmidt
2009-10-31 9:31 ` Rafael J. Wysocki
2009-10-31 21:01 ` Benjamin Herrenschmidt
2009-10-31 21:27 ` Rafael J. Wysocki
2009-10-31 21:44 ` Linus Torvalds
2009-10-31 21:52 ` Rafael J. Wysocki
[not found] ` <200910312252.39446.rjw-KKrjLPT3xs0@public.gmane.org>
2009-10-31 21:57 ` Linus Torvalds
[not found] ` <alpine.LFD.2.01.0910311455520.31845-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-10-31 22:10 ` Rafael J. Wysocki
[not found] ` <200910312227.15493.rjw-KKrjLPT3xs0@public.gmane.org>
2009-10-31 22:56 ` Benjamin Herrenschmidt
2009-10-31 23:10 ` Rafael J. Wysocki
2009-10-31 23:24 ` Rafael J. Wysocki
2009-11-01 8:36 ` Rafael J. Wysocki
2009-11-01 16:47 ` Dominik Brodowski
[not found] ` <20091101164736.GA5666-S7uyTPAaJ/sb6pqDj42GsMgv3T4z79SOrE5yTffgRl4@public.gmane.org>
2009-11-02 13:35 ` Rafael J. Wysocki
[not found] ` <200911010936.10409.rjw-KKrjLPT3xs0@public.gmane.org>
2009-11-01 17:18 ` Linus Torvalds
2009-11-02 13:39 ` Rafael J. Wysocki
2009-11-02 17:38 ` Dominik Brodowski
[not found] ` <20091102173843.GA662-S7uyTPAaJ/sb6pqDj42GsMgv3T4z79SOrE5yTffgRl4@public.gmane.org>
2009-11-02 18:40 ` Rafael J. Wysocki
[not found] ` <200911021439.28266.rjw-KKrjLPT3xs0@public.gmane.org>
2009-11-02 17:50 ` Linus Torvalds
2009-11-02 22:22 ` Benjamin Herrenschmidt [this message]
2009-11-12 12:14 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257200523.7907.53.camel@pasglop \
--to=benh-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
--cc=braket-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-X3ehHDuj6sIIGcDfoQAp7OTW4wlIGRCZ@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox